[codex] Fix preview test and extend mocha timeout#17
Merged
ultmaster merged 1 commit intomicrosoft:mainfrom Jun 19, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the testing framework for the extension by removing jest mocks and converting tests to mocha, along with extending the mocha timeout and updating workflow configurations.
- Migrated tests from Jest to Mocha
- Updated VS Code test runner configuration and fixture paths
- Extended test timeout for preview command and updated GitHub workflows
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/poml-vscode/tests/preview.test.ts | Adds a test for the preview command with an extended timeout |
| packages/poml-vscode/tests/panelContent.test.ts | Implements panel content helper test |
| packages/poml-vscode/tests/extension.test.ts | Updates extension activation verification test |
| packages/poml-vscode/tests/commands.test.ts | Verifies the registration of multiple commands |
| packages/poml-vscode/test-fixtures/test.poml | Provides a new fixture for testing the preview command |
| .vscode-test.mjs | Adjusts the file glob pattern to point to the correct test location |
| .github/workflows/test.yml | Updates CI workflows to run tests appropriately on Linux and non-Linux runners |
Comments suppressed due to low confidence (1)
packages/poml-vscode/tests/preview.test.ts:15
- The test currently only asserts truthiness with 'assert.ok(true)', which does not validate the actual behavior of the preview command. Consider adding specific assertions to verify that the preview has been rendered or updated as expected.
assert.ok(true);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npm test -- -w=packages/poml/testsxvfb-run -a npm run test-vscodehttps://chatgpt.com/codex/tasks/task_e_6853afb47a1c832e91d8c01ae716bf30