Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates documentation for POML trace functionality and fixes bugs related to OpenAI API format handling. The changes focus on improving POML's integration capabilities and adding comprehensive documentation for Python integrations.
- Fixes OpenAI Chat Completion API format issues in tool definitions and response format schemas
- Adds extensive documentation for Python integrations (OpenAI, LangChain, MCP, MLflow, AgentOps, Weave)
- Enhances tracing functionality with better context handling and local variable scoping
Reviewed Changes
Copilot reviewed 37 out of 46 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
python/tests/test_poml_formats.py |
Fixes OpenAI format structure by adding missing wrapper objects for tools and response_format |
python/tests/test_examples.py |
Adds context file loading support for example tests |
python/tests/integration/ |
Adds comprehensive integration test files for OpenAI, MCP server functionality |
python/tests/assets/ |
Adds POML template files for testing tool calls, response formats, and dynamic tools |
python/poml/api.py |
Fixes OpenAI format generation to properly wrap tools and response_format schemas |
packages/poml/file.tsx |
Improves let variable handling with better local vs global context separation |
docs/python/ |
Adds comprehensive integration documentation for multiple platforms |
examples/ |
Adds math calculation example files with context support |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds documentation and CI support for new integrations (MCP and OpenAI), and improves test workflows to handle context files and additional integration scenarios. The main changes are grouped into documentation additions for new integrations, and enhancements to the GitHub Actions workflows for broader integration testing and context-aware execution.
Documentation for new integrations:
docs/python/integration/agentops.md)docs/python/integration/langchain.md)docs/python/integration/mcp.md)GitHub Actions workflow enhancements:
mcpandopenaiin addition to existing integrations, enabling automated testing for these new integrations. (.github/workflows/test-integration.yml,.github/workflows/shared-test-integration.yml) [1] [2] [3]openai. (.github/workflows/shared-test-integration.yml) [1] [2] [3]Test execution improvements:
.context.jsonfile and use it if available, both forpomlandpoml-clicommands. (.github/workflows/test-after-publish.yml) [1] [2]