Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates integration testing workflows and improves test output formatting. It refactors GitHub Actions to use shared workflow patterns and standardizes status messages across test utilities.
- Replaces individual GitHub Action composite actions with a reusable workflow pattern
- Updates test output messages to use bracketed prefixes ([OK], [ERROR], [SUCCESS])
- Adds missing dependencies to support langchain integration tests
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| python/tests/integration/weave_utils.py | Updates status messages to use bracketed format for consistency |
| python/tests/integration/mlflow_utils.py | Updates status messages to use bracketed format for consistency |
| python/tests/integration/common_utils.py | Fixes print_separator formatting to apply color to title text |
| pyproject.toml | Adds langchain-openai and openai dependencies for agent extras |
| .github/workflows/test-integration.yml | Refactors to use shared workflow instead of composite action |
| .github/workflows/shared-test-integration.yml | New reusable workflow consolidating integration test logic |
| .github/workflows/shared-check-version.yml | Renames workflow for consistency with shared naming pattern |
| .github/workflows/publish-vscode.yml | Updates reference to renamed shared workflow |
| .github/workflows/publish-pypi.yml | Updates reference to renamed shared workflow |
| .github/workflows/publish-npm.yml | Updates reference to renamed shared workflow |
| .github/actions/test-integration/action.yml | Removes composite action replaced by shared workflow |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| - name: Setup MLflow tracking server | ||
| if: inputs.integration == 'mlflow' | ||
| run: | |
There was a problem hiding this comment.
The MLflow server command has added --default-artifact-root ./mlartifacts parameter that wasn't present in the original action. This change should be documented or verified as intentional to ensure artifact storage works correctly.
Suggested change
| run: | | |
| run: | | |
| # Use a custom artifact root to avoid polluting the default ./mlruns directory in CI. | |
| mkdir -p ./mlartifacts |
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.