Remove accessibility insights eslint plugin#116
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the @accessibility-insights/eslint-plugin dependency and its associated configuration from the project. The changes simplify the linting setup by removing the accessibility insights plugin from the ESLint configuration and deleting the npm registry configuration that was used to install it.
- Removes
@accessibility-insights/eslint-pluginfrom devDependencies - Cleans up ESLint configuration by removing accessibility insights plugin references
- Deletes
.npmrcfile that pointed to internal accessibility insights registry
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Removes the accessibility insights ESLint plugin dependency |
| .npmrc | Deletes npm registry configuration for accessibility insights package |
| .eslintrc.js | Removes all references to accessibility insights plugin from ESLint configuration |
Comments suppressed due to low confidence (1)
.eslintrc.js:1
- The require statement for '@accessibility-insights/eslint-plugin' is being removed but the package is also being removed from devDependencies. This will cause a runtime error if ESLint tries to load this configuration before the package is uninstalled. Consider removing this line in the same commit that removes the package dependency.
module.exports = {
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ultmaster
deleted the
codex/investigate-rce-vulnerability-from-unclaimed-package
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@accessibility-insights/eslint-pluginand related config.npmrcreferencing internal registryTesting
npm run build-webviewnpm run build-clinpm run lintnpm testpython -m pytest python/testshttps://chatgpt.com/codex/tasks/task_e_68a3c8a8d774832eb12e169691d42df2