fix: Start install with no new window #2489
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running Playwright.Main(new [] {install}) shows console window in WPF app, which does not show in normal test. In normal test we are already running under existing conhost which is started as hidden so we don't show extra window. In WPF app that uses WinExe and has no existing conhost a new console is shown for playwright.cmd. This PR makes sure that window is hidden.
Fixes microsoft#2462
Member
Author
|
Not sure how to write a test for this, without it being super heavyweight, you will have to believe me I guess: BEFORE:
AFTER:
|
Member
Author
|
@mxschmitt please advise on the driver failure. I guess I can just push the version up to 1.31.0? But is that something you see often? |
Member
Author
|
Okay so apparently this would partially #2451, which in turn was breaking progress from installation (because it was not inteactive anymore), and would not correctly forward the output. WindowStyle Hidden also does not work, becuase it has no effect. So unless progress stops requiring interactive shell there is no solution. |
Member
FWIW we added support for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running Playwright.Main(new [] { "install" }) shows console window in WPF app, which does not show in normal test. In normal test we are already running under existing conhost which is started as hidden so we don't show extra window. In WPF app that uses WinExe and has no existing conhost a new console is shown for playwright.cmd. This PR makes sure that the window is hidden.
Fixes #2462