refactor: remove browserPaths in favor of Registry class#5318
Merged
Conversation
This patch introduces a new Registry class that incapsulates all logic regarding browsers and their paths. Fixes microsoft#5278
aslushnikov
force-pushed
the
refactor-browser-paths
branch
from
4c7997e to
af14e8d
Compare
aslushnikov
changed the title
dgozman
reviewed
Feb 5, 2021
dgozman
approved these changes
Feb 6, 2021
mxschmitt
added a commit
to mxschmitt/playwright
that referenced
this pull request
Apr 12, 2021
This fixes the compatibility on Vercel with Next.js when it's used in a serverless function. Next.js uses https://github.com/vercel/nft to trace down the dependencies which a serverless function is using which is currently not capable of detecting the browsers.json in our current setup. Previously we used require to load the browers.json which was replaced by readFileSync in microsoft#5318. Since then it was broken. Fixes microsoft#5862
mxschmitt
added a commit
to mxschmitt/playwright
that referenced
this pull request
Apr 12, 2021
This fixes the compatibility on Vercel with Next.js when it's used in a serverless function. Next.js uses https://github.com/vercel/nft to trace down the dependencies which a serverless function is using which is currently not capable of detecting the browsers.json in our current setup. Previously we used require to load the browers.json which was replaced by readFileSync in microsoft#5318. Since then it was broken. Fixes microsoft#5862
mxschmitt
added a commit
that referenced
this pull request
Apr 19, 2021
This fixes the compatibility on Vercel with Next.js when it's used in a serverless function. Next.js uses https://github.com/vercel/nft to trace down the dependencies which a serverless function is using which is currently not capable of detecting the browsers.json in our current setup. Previously we used require to load the browers.json which was replaced by readFileSync in #5318. Since then it was broken. Fixes #5862
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch introduces a new Registry class that incapsulates
all logic regarding browsers and their paths.
Fixes #5278