Skip to content

chore: remove firefox-beta and chromium-tip-of-tree channels - #42030

Merged
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom
dgozman:remove-firefox-beta-tot
Jul 29, 2026
Merged

Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom
dgozman:remove-firefox-beta-tot

Conversation

@dgozman

Copy link
Copy Markdown
Collaborator

Summary

  • Remove firefox-beta, chromium-tip-of-tree and chromium-tip-of-tree-headless-shell from the registry, browsers.json and install aliases.
  • Remove the tip-of-tree headless shell mapping in getExecutableName and related test skips.
  • Remove firefox-beta support from utils/roll_browser.js.

The moz-firefox-beta channel (system-installed Firefox Beta) and allDownloadableDirectoriesThatEverExisted are intentionally untouched.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

7 flaky ⚠️ [chromium-library] › library/chromium/chromium.spec.ts:299 › should report intercepted service worker requests in HAR `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:664 › screencast › should capture full viewport `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:664 › screencast › should capture full viewport `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:495 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/har-websocket.spec.ts:231 › should embed websocket messages `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node20`

50816 passed, 1188 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [webkit] › mcp/annotate.spec.ts:349 › should annotate when context has no fixed viewport @mcp-windows-latest-webkit

7807 passed, 1266 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 CI is clear — the one failure is a pre-existing flake

Hi, I'm the Playwright bot and I took a first look at the CI failures.

The only real failure is mcp/annotate.spec.ts:349 › should annotate when context has no fixed viewport on mcp-windows-latest-webkit, and it's a pre-existing Windows flake — the same test failed on unrelated PR #41978. This PR only removes the firefox-beta / chromium-tip-of-tree channels, which the WebKit MCP annotate flow never touches. Nothing here looks caused by your change.

Details

Overall: The tests 1 report has 7 flaky and 0 failed, so nothing to triage there. The MCP report has a single real failure, covered below.

Pre-existing flake / infra

  • [webkit] › mcp/annotate.spec.ts:349 › should annotate when context has no fixed viewport (@mcp-windows-latest-webkit) — flake. It fails on getByRole('main', { name: 'Dashboard: annotate' }) never becoming visible, with McpError: MCP error -32000: Connection close while the localhost navigation never finishes — a connection/timing signature, not a deterministic assertion failure.
    • Across the CI results DB this exact (file, test_title) failed just twice: here, and on unrelated PR Revert "chore(deps-dev): bump fast-uri from 3.1.3 to 3.1.4" #41978 (revert-…/fast-uri-3.1.4, a Dependabot revert) on mcp-windows-latest-firefox — same "Dashboard: annotate not visible / navigation never finishes" signature (run 30094109519). A PR that reverts a fast-uri bump can't be responsible for this test, so it's not PR-specific.
    • It's engine-independent (seen on both WebKit and Firefox) but Windows-only, and rare: mcp-windows-latest-webkit passed 281 of 282 recorded runs of this test, the single red being this PR's run.
    • The diff can't reach it: the changed files are registry/index.ts, browsers.json, chromium.ts (getExecutableName tip-of-tree mapping), roll_browser.js, and a few test skips — none touch WebKit, MCP, or the annotate dashboard. Removing the firefox-beta/chromium-tot channels has no path to a WebKit MCP navigation timeout.

I'm a first pass, not the final word — but the same-test failure on an unrelated PR is solid enough that I'd re-run the MCP job and move on.

Triaged by the Playwright bot - agent run

@dgozman
Dmitry Gozman (dgozman) merged commit beaf223 into microsoft:main Jul 29, 2026
49 of 50 checks passed
@cscheffauer

Copy link
Copy Markdown

Dmitry Gozman (@dgozman) is there any detailed information about why firefox-beta was removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants