fix(ui): Wait with polling if test is still scheduled#38656
fix(ui): Wait with polling if test is still scheduled#38656Skn0tt merged 2 commits intomicrosoft:mainfrom
Conversation
Skn0tt
left a comment
There was a problem hiding this comment.
Sorry for the late review. The change looks good, but I wonder about the test.
Test results for "tests 1"26 failed 2 flaky34580 passed, 691 skipped Merge workflow run. |
Test results for "MCP"1 failed 2829 passed, 121 skipped Merge workflow run. |
Don't poll if the selected test is still selected. Wait for a response from the websocket instead that the test has started (that updates
itemprop). This polling fetch would fail (sw errors), causing the model to be set to a newTraceModelwith an emptytraceURI, which in case would make the source call fail (the original issue).Added assertions to existing test.
Closes: #38359