Skip to content

fix(trace): operate trace uri, not path#38566

Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman:trace_uri
Dec 16, 2025
Merged

fix(trace): operate trace uri, not path#38566
pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman:trace_uri

Conversation

@pavelfeldman
Copy link
Member

@pavelfeldman pavelfeldman commented Dec 15, 2025

Fixes #38551

@github-actions

This comment has been minimized.

Sign in to view
yury-s
yury-s approved these changes Dec 16, 2025
View reviewed changes
@pavelfeldman
Copy link
Member Author

pavelfeldman commented Dec 16, 2025

@cpAdm do you want to review this one? We used to pass absolute file path into traceURL and I replaced it with the uri that contains path + timestamp.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
cpAdm
cpAdm reviewed Dec 16, 2025
View reviewed changes
Copy link
Contributor

@cpAdm cpAdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that these changes fixes the related issue. But whilst add it, I think we should try to solve #38364 as well

packages/trace-viewer/src/ui/uiModeTraceView.tsx
@@ -65,14 +65,14 @@ export const TraceView: React.FC<{

const traceLocation = [
Copy link
Contributor

@cpAdm cpAdm Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fetching this resource always fails

Copy link
Member Author

@pavelfeldman pavelfeldman Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean? No live traces tests would pass if this failed.

@pavelfeldman pavelfeldman reopened this Dec 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025

Test results for "tests 1"

2 failed
❌ [playwright-test] › web-server.spec.ts:25 › should create a server @windows-latest-node20-2
❌ [playwright-test] › web-server.spec.ts:555 › should create multiple servers @windows-latest-node20-2

1 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1083 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`

34366 passed, 692 skipped

Merge workflow run.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025

Test results for "MCP"

5 failed
❌ [chromium] › mcp/screenshot.spec.ts:222 › browser_take_screenshot (filename: "output.png") @mcp-macos-15
❌ [chromium] › mcp/video.spec.ts:21 › should work with --save-video (isolated) @mcp-macos-15
❌ [chromium] › mcp/video.spec.ts:63 › should work with recordVideo (isolated) @mcp-macos-15
❌ [chromium] › mcp/video.spec.ts:21 › should work with --save-video (persistent) @mcp-macos-15
❌ [chromium] › mcp/video.spec.ts:63 › should work with recordVideo (persistent) @mcp-macos-15

2709 passed, 116 skipped

Merge workflow run.

@pavelfeldman pavelfeldman merged commit 185bfb7 into microsoft:main Dec 16, 2025
53 of 61 checks passed
This was referenced Dec 16, 2025
Open
Closed
Open
@cpAdm cpAdm mentioned this pull request Dec 17, 2025
Closed
pavelfeldman added a commit that referenced this pull request Dec 17, 2025
@pavelfeldman
cherry-pick(#38566): fix(trace): operate trace uri
539000b
whazor pushed a commit to whazor/playwright-trace-viewer-plus that referenced this pull request Jan 10, 2026
@pavelfeldman
fix(trace): operate trace uri, not path (microsoft#38566)
c99af5f
This was referenced Feb 3, 2026
Closed
Closed
@Skn0tt Skn0tt mentioned this pull request Feb 4, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yury-s yury-s yury-s approved these changes

+1 more reviewer

@cpAdm cpAdm cpAdm left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Regression]: UI does not update actions (and more) for a re-run

3 participants

@pavelfeldman @yury-s @cpAdm