Skip to content

Conversation

@yury-s
Copy link
Member

@yury-s yury-s commented Oct 15, 2025

Feature status: https://chromestatus.com/feature/5152728072060928 Looks like it got enabled between 1.56.0-alpha-2025-09-12 and 1.56.0-alpha-2025-09-11 which correspond to Chromium 141.0.7390.16 and 141.0.7390.7.

Blink thread: https://groups.google.com/a/chromium.org/g/blink-dev/c/cwu_RUmBpzY?utm_source=chatgpt.com&pli=1

Fixes #37861

@yury-s
Copy link
Member Author

yury-s commented Oct 15, 2025

Not sure if we want to support this, given that "permission prompt for Local Network Access" is still an [opt-in experiment]( permission prompt for Local Network Access) in Chrome.

Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one is good. It looks like LNA is going to be enabled by default in 142 (https://chromestatus.com/feature/5152728072060928), so unblocking this usecase is nice. I am afraid that we'll have to disable it if too many customers are affected in the next release.

Can we add a test, or is that too hard given the IP shenanigans?

@jgoz
Copy link

jgoz commented Oct 15, 2025

Thank you for the quick turnaround on this!

I am afraid that we'll have to disable it if too many customers are affected in the next release.

I commented about this here: #37861 (comment)

My gut feeling is that most people won't be affected by this because they will likely fall into "all private" or "all public" buckets of access patterns. We were affected because our desire for consistent infrastructure between dev/staging/prod meant putting the root URL behind CF (technically making it public) while other services were kept private.

But it will be nice to have an escape hatch for those of us in the unconventional "public -> private" bucket.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@yury-s yury-s force-pushed the cr-localNetworkAccess branch from c89ece1 to f02fa79 Compare October 16, 2025 23:25
@github-actions
Copy link
Contributor

Test results for "MCP"

2570 passed, 108 skipped


Merge workflow run.

@yury-s yury-s merged commit eed1f19 into microsoft:main Oct 16, 2025
34 of 35 checks passed
@yury-s yury-s deleted the cr-localNetworkAccess branch October 16, 2025 23:59
yury-s added a commit that referenced this pull request Oct 17, 2025
@github-actions
Copy link
Contributor

Test results for "tests 1"

2 failed
❌ [playwright-test] › runner.spec.ts:118 › should ignore subprocess creation error because of SIGINT @macos-latest-node18-1
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:204 › should not preserve selection across test runs @macos-latest-node18-1

2 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node18`
⚠️ [playwright-test] › ui-mode-test-attachments.spec.ts:21 › should contain text attachment `@windows-latest-node18-1`

47095 passed, 815 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accept local-network-access permission

4 participants