Revert "fix: get rid of url.parse in network code" #36654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 56594a0.
dgozman
approved these changes
Jul 11, 2025
Contributor
Test results for "tests 1"8 flaky46731 passed, 926 skipped Merge workflow run. |
Skn0tt
added a commit
that referenced
this pull request
Jul 11, 2025
Skn0tt
added a commit
to Skn0tt/playwright
that referenced
this pull request
Jul 14, 2025
This reverts commit 7fed46b, keeping the added test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #36423
Closes #36650