Skip to content

fix(trace): include method into "Fetch" action title #36350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dgozman merged 1 commit into from
Jun 18, 2025
Merged

fix(trace): include method into "Fetch" action title #36350

dgozman merged 1 commit into from
Jun 18, 2025

Conversation

@dgozman
Copy link
Contributor

@dgozman dgozman commented Jun 18, 2025

HTML report

Screenshot 2025-06-18 at 12 00 38 PM

Trace viewer

Screenshot 2025-06-18 at 12 01 10 PM

@dgozman dgozman requested a review from mxschmitt June 18, 2025 11:01
mxschmitt
mxschmitt approved these changes Jun 18, 2025
View reviewed changes
@github-actions

This comment has been minimized.

Sign in to view
@dgozman dgozman force-pushed the fix-fetch-action-title branch from 7b85270 to 6b14f66 Compare June 18, 2025 11:59
@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025

Test results for "tests 1"

8 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-event-request.spec.ts:182:3 › should return response body when Cross-Origin-Opener-Policy is set @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:82:3 › should click the button with offset with page scale @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1
⚠️ [playwright-test] › ui-mode-trace.spec.ts:154:5 › should show snapshots for steps @windows-latest-node18-1

39369 passed, 818 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit f050c3f into microsoft:main Jun 18, 2025
28 of 29 checks passed
This was referenced Jun 18, 2025
Closed
Closed
Closed
dgozman added a commit to dgozman/playwright that referenced this pull request Jun 18, 2025
@dgozman
cherry-pick(microsoft#36350): fix(trace): include method into "Fetch"…
ba6f956 
… action title
dgozman added a commit that referenced this pull request Jun 18, 2025
@dgozman
cherry-pick(#36350): fix(trace): include method into "Fetch" action t…
b7032c2 
…itle (#36352)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mxschmitt mxschmitt mxschmitt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dgozman @mxschmitt