fix(blob): properly communicate attachments through blob merges #35517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agg23
force-pushed
the
blob-merge-attachment-fix
branch
from
3393482 to
9ed7111
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dgozman
reviewed
Apr 8, 2025
This comment has been minimized.
This comment has been minimized.
dgozman
reviewed
Apr 16, 2025
dgozman
reviewed
Apr 16, 2025
dgozman
approved these changes
Apr 16, 2025
dgozman
approved these changes
Apr 16, 2025
Contributor
Test results for "tests 1"1 failed 5 flaky39034 passed, 924 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some restructuring of the blob format resulted in attachment data not being available by the time
onStepEndis sent during a blob merge. This results in attachments going missing for any dependent reporters.Introduce the internal
onAttachevent as something emitted by blob to properly reconstruct the event log through a merge. This does not affect the public API and gracefully falls back if an older reporter created the blob.