feat(ui-mode): add key shortcuts for playwright uI test runner #29868
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| sendMessageNoReply('stop'); | ||
| } else if (e.code === 'KeyU' && (e.metaKey || e.ctrlKey)) { | ||
| e.preventDefault(); | ||
| reloadTests(); |
There was a problem hiding this comment.
I feel like KeyR should be reload which seems more natural to the users. Maybe Enter+Command should be run?
There was a problem hiding this comment.
I feel like KeyR should be reload which seems more natural to the users. Maybe Enter+Command should be run?
Thank you for your reply.
Then I'll change it to Enter+Command.
This comment has been minimized.
This comment has been minimized.
|
As comments are edited |
This comment has been minimized.
This comment has been minimized.
|
Sorry for the late reply. We thought a little bit about it, when you are on a test item, you can already as of today press Enter in order to run a test. So I'd start with F5 / F6 now for reloading and stopping the current tests. What do you think? I pushed to your branch, but need to adjust tests. |
|
F5 / F6 are also good. |
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"8 flaky26830 passed, 620 skipped Merge workflow run. |
2 participants
related issue: #28899
Motivation:
Introduce keyboard shortcuts for common actions in the Playwright UI test runner to enhance developer productivity and streamline the test execution process.
Modification:
Make shortcut keydown event in
uiModeView.tsxResult: