feat: Service Worker Network Instrumentation and Inspection #14716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meir017
reviewed
Jun 27, 2022
dgozman
approved these changes
Jun 28, 2022
|
This is ready to land. However, we're still iterating on har bits for some post-1.23 follow up, so it doesn't make sense to land this quite yet as it will make patching 1.23 quite a nuisance due to the HAR overlap. Once 1.23 settles a bit more, we will land this. |
|
CR stable bots yelled. Need to flag off some of the tests on < 104 (https://storage.googleapis.com/chromium-find-releases-static/d5f.html#d5ffe2b9df217ce727347612361bd81d5e3eb648) |
commit 0ed3d32 Author: Ross A. Wollman <[email protected]> Date: Fri Jul 1 10:55:53 2022 -0700 skip select tests until after roll commit e4de45c Merge: 5cbcfe9 b86926e Author: Ross A. Wollman <[email protected]> Date: Thu Jun 30 17:27:00 2022 -0700 Merge branch 'main' into feat/sw-chunked commit 5cbcfe9 Author: Ross A. Wollman <[email protected]> Date: Tue Jun 28 12:50:15 2022 -0700 lint commit 7e2d70b Author: Ross A. Wollman <[email protected]> Date: Tue Jun 28 12:23:22 2022 -0700 clean up more tests commit 403e2f3 Author: Ross A. Wollman <[email protected]> Date: Tue Jun 28 12:09:41 2022 -0700 remove skips commit f72f811 Author: Ross A. Wollman <[email protected]> Date: Mon Jun 27 22:49:25 2022 -0700 fix indentation from conflict resolution commit c3afbb2 Author: Ross A. Wollman <[email protected]> Date: Mon Jun 27 22:45:28 2022 -0700 lint commit a17e73c Merge: 7cb20b9 43a621e Author: Ross A. Wollman <[email protected]> Date: Mon Jun 27 22:36:59 2022 -0700 Merge branch 'main' into feat/sw-chunked commit 7cb20b9 Merge: a29f898 0f8114f Author: Ross Wollman <[email protected]> Date: Mon Jun 20 19:49:19 2022 -0700 Merge branch 'main' into feat/sw-chunked commit a29f898 Author: Ross A. Wollman <[email protected]> Date: Tue Jun 14 10:54:23 2022 -0700 fix tests post merge commit 42c7d9d Merge: 4eeca70 4f1ab2f Author: Ross Wollman <[email protected]> Date: Tue Jun 14 09:32:59 2022 -0700 Merge branch 'main' into feat/sw-chunked commit 4eeca70 Merge: 0aaab65 939e187 Author: Ross Wollman <[email protected]> Date: Mon Jun 13 11:35:57 2022 -0700 Merge branch 'main' into feat/sw-chunked commit 0aaab65 Merge: 907c1a3 e975aef Author: Ross Wollman <[email protected]> Date: Thu Jun 9 00:56:29 2022 -0400 Merge branch 'main' into feat/sw-chunked commit 907c1a3 Author: Ross A. Wollman <[email protected]> Date: Wed Jun 8 13:17:01 2022 -0400 feat: add Service Worker Network instrumentation
|
Reviewed CQ1 status, and got verbal LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Chromium support for Service Worker Networking (interception/routing, Request/Response events, and HAR).
Landed upstream patches:
TODO:
Resolves #1090.
Depends on #14714 and #14714.
Supercedes #14321.