feat: add allow/block serviceWorkers option #14714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
pavelfeldman
reviewed
Jun 8, 2022
pavelfeldman
approved these changes
Jun 8, 2022
rwoll
commented
Jun 8, 2022
dgozman
approved these changes
Jun 8, 2022
rwoll
added a commit
that referenced
this pull request
Jul 1, 2022
…#14716) Adds Chromium support for Service Worker Networking (interception/routing, Request/Response events, and HAR). Resolves #1090. Depends on #14714 and #14714. Supercedes #14321. Follow up #14711. Landed upstream patches: - https://chromium-review.googlesource.com/c/chromium/src/+/3510917 - https://chromium-review.googlesource.com/c/chromium/src/+/3526571 - https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3566669 - https://chromium-review.googlesource.com/c/chromium/src/+/3544685 - https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3610924 - https://chromium-review.googlesource.com/c/chromium/src/+/3689949
orenyomtov
added a commit
to orenyomtov/playwright
that referenced
this pull request
Jan 4, 2023
In the implementation of adding the serviceWorkers option (microsoft#14714), the default value was not properly set. This PR fixes the workaround needed here: microsoft#15684 (comment) As you can see, it is documented to default to `"allow"`: https://github.com/rwoll/playwright/blob/main/docs/src/api/params.md#context-option-service-worker-policy Signed-off-by: Oren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds cross-browser support for easily allowing/blocking Service Workers via a Context option.
Includes plumbing for Playwright Test's
use.Resolves #14522.
Relates #1090.
Supercedes #14321.