Repository navigation
[Feature] Acces to the locator selector #10178
Description
Let us know what functionality you'd like to see in Playwright and what your use case is.
Do you think others might benefit from this as well?
Hey,
we would like to have access to the selector of our locator. Thanks to that solution we can create methods which can enhance/modify our base selector.
Example
and then we can implement such thing:
class Header extends PageObjectComponent {
$ = {
button: this.page.locator('[e2e-target=button]'),
}
constructor(page) {
super(page, page.locator('[e2e-target="header"]'))
}
async hoverOnHeader(): Promise<void> {
await this.parentElement.hover()
}
}
class LandingPage extends PageObject {
$ = {
footer: new Footer(this.page),
header: new Header(this.page),
}
constructor(page) {
super(page, landingPageUrl)
}
async waitForPageLoad(): Promise<void> {
await this.$.header.hoverOnHeader()
}
async clickConfirmButton Promise(): void {
const baseSelector: string = this.$.header.$.button.selector
await this.page.locator(`${baseSelector}[e2e-target-name="confirm"]`).click()
}
}
Reacted by Marcin
Activity
pavelfeldman commentedon Nov 9, 2021
Looks like if we address #10177, you wouldn't need this one, right?
Evilweed commentedon Nov 9, 2021
Pavel Feldman (@pavelfeldman) i think it would be still useful to be able to create selectors that cannot be created with
.withAttribute()For example to create equivalents of:
withText()withExactText()Seems like
.withAttribute()is easier to use, but this seems to be more powerful:pavelfeldman commentedon Nov 10, 2021
Selector is an implementation detail of the locator, we can't create locator from selector in the general case. But we can try amending conditions like you attribute. I'll close this one in favor of withAttribute. We already have text and exact text matching via adding
.locator('text=Hello').Evilweed commentedon Nov 10, 2021
Pavel Feldman (@pavelfeldman) if you are implementing only withAttribute() then i need to open new feature requests for withText() and withExactText() (or withText with regexp support).
This is because withAttribute() and your suggested
.locator('text=Hello')does not solve my problem entirely :)withAttribute() already exists too, it is
.locator([attribute-name="someValue"])so in theory anyone could use this, but what we need is to be able to extend current locator instead of searching for new thing within parent locator.So much easier to create DRY code like that:
Than this: