Repository navigation
Commit f5c0b22
committed
fix(routeFromHar): address follow-up review feedback on interceptAPIRequests
- abort HAR lookup errors when notFound:'abort' (was silently falling through)
- iterate a copy of the registrations to survive concurrent unroute
- close the HAR last in HarRouter.dispose, after unrouting API registrations
- look up LocalUtils via a typed DispatcherConnection.getDispatcher<T>() helper
instead of an inline _dispatcherByGuid scan
- assert response.serverAddr() in the intercepted-request test (record in 'full'
mode so serverIPAddress/serverPort are persisted)1 parent 9fab9ca commit f5c0b22
5 files changed
Lines changed: 18 additions & 9 deletions
File tree
- packages/playwright-core/src
- client
- server
- dispatchers
- tests/library
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
139 | | - | |
140 | 139 | | |
141 | 140 | | |
142 | 141 | | |
| 142 | + | |
143 | 143 | | |
144 | 144 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
342 | 342 | | |
343 | 343 | | |
344 | 344 | | |
345 | | - | |
346 | | - | |
| 345 | + | |
347 | 346 | | |
348 | 347 | | |
349 | 348 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
263 | 263 | | |
264 | 264 | | |
265 | 265 | | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
266 | 274 | | |
267 | 275 | | |
268 | 276 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
709 | 709 | | |
710 | 710 | | |
711 | 711 | | |
712 | | - | |
713 | | - | |
714 | | - | |
715 | | - | |
716 | | - | |
| 712 | + | |
| 713 | + | |
| 714 | + | |
717 | 715 | | |
718 | 716 | | |
719 | 717 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
867 | 867 | | |
868 | 868 | | |
869 | 869 | | |
870 | | - | |
| 870 | + | |
| 871 | + | |
871 | 872 | | |
872 | 873 | | |
873 | 874 | | |
| |||
880 | 881 | | |
881 | 882 | | |
882 | 883 | | |
| 884 | + | |
| 885 | + | |
| 886 | + | |
883 | 887 | | |
884 | 888 | | |
885 | 889 | | |
| |||
0 commit comments