Skip to content

Commit f4727a6

Browse files
scs0209cursoragent
andcommitted
test(trace-viewer): drop redundant a11y regression tests
Per review feedback, remove standalone filter-name and keyboard source tests; the network filter assertion in the existing spec is enough. Co-authored-by: Cursor <[email protected]>
1 parent 39efc67 commit f4727a6

2 files changed

Lines changed: 0 additions & 24 deletions

File tree

‎tests/library/trace-viewer.spec.ts‎

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1364,24 +1364,6 @@ test('should highlight expect failure', async ({ page, server, runAndTrace }) =>
13641364
await expect(traceViewer.errorMessages.nth(0)).toHaveText('Expect failed');
13651365
});
13661366

1367-
test('should open error source from the keyboard', async ({ page, server, runAndTrace }) => {
1368-
test.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/42463' });
1369-
const traceViewer = await runAndTrace(async () => {
1370-
try {
1371-
await page.goto(server.EMPTY_PAGE);
1372-
await expect(page).toHaveTitle('foo', { timeout: 100 });
1373-
} catch (e) {
1374-
}
1375-
});
1376-
1377-
await traceViewer.showErrorsTab();
1378-
const sourceLink = traceViewer.page.getByRole('button', { name: /Go to source:/ });
1379-
await expect(sourceLink).toBeVisible();
1380-
await sourceLink.focus();
1381-
await sourceLink.press('Enter');
1382-
await expect(traceViewer.page.getByRole('tab', { name: 'Source', selected: true })).toBeVisible();
1383-
});
1384-
13851367
test('should show action source', async ({ showTraceViewer }) => {
13861368
const traceViewer = await showTraceViewer(traceFile);
13871369
await traceViewer.selectAction('Click');

‎tests/playwright-test/ui-mode-test-filters.spec.ts‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -91,12 +91,6 @@ test('should toggle filters from the keyboard', async ({ runUITest }) => {
9191
await expect(summary).toHaveAttribute('aria-expanded', 'false');
9292
});
9393

94-
test('should expose an accessible name for the filter input', async ({ runUITest }) => {
95-
test.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/42463' });
96-
const { page } = await runUITest(basicTestTree);
97-
await expect(page.getByRole('searchbox', { name: 'Filter (e.g. text, @tag)' })).toBeVisible();
98-
});
99-
10094
test('should filter by status', async ({ runUITest }) => {
10195
const { page } = await runUITest(basicTestTree);
10296

0 commit comments

Comments
 (0)