Skip to content

Commit ba50778

Browse files
authored
fix(mcp): assign caps as array for legacy --vision flag (#41253)
1 parent b8ee5ae commit ba50778

2 files changed

Lines changed: 12 additions & 1 deletion

File tree

‎packages/playwright-core/src/tools/mcp/program.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,8 @@ export function decorateMCPCommand(command: Command) {
8888
if (options.vision) {
8989
// eslint-disable-next-line no-console
9090
console.error('The --vision option is deprecated, use --caps=vision instead');
91-
options.caps = 'vision';
91+
options.caps ??= [];
92+
options.caps.push('vision');
9293
}
9394

9495
if (options.caps?.includes('tracing'))

‎tests/mcp/capabilities.spec.ts‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,3 +75,13 @@ test('support for legacy --vision option', async ({ startClient }) => {
7575
expect(toolNames).toContain('browser_mouse_click_xy');
7676
expect(toolNames).toContain('browser_mouse_drag_xy');
7777
});
78+
79+
test('legacy --vision option combined with --caps', async ({ startClient }) => {
80+
const { client } = await startClient({
81+
args: ['--vision', '--caps=pdf'],
82+
});
83+
const { tools } = await client.listTools();
84+
const toolNames = tools.map(t => t.name);
85+
expect(toolNames).toContain('browser_mouse_move_xy');
86+
expect(toolNames).toContain('browser_pdf_save');
87+
});

0 commit comments

Comments
 (0)