Skip to content

Comments

Bump ORT to 1.15 | chore(deps)#770

Merged
justinchuby merged 6 commits intomainfrom
justinchu/ort-1.15
Jun 9, 2023
Merged

Bump ORT to 1.15 | chore(deps)#770
justinchuby merged 6 commits intomainfrom
justinchu/ort-1.15

Conversation

@justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Jun 8, 2023

This change updates ORT and ort-nightly to the latest versions and cleans up the skipped tests. It also generates opset19 so that the backend tests can run.

@justinchuby justinchuby requested a review from jcwchen June 8, 2023 16:04
@justinchuby justinchuby added the merge at lgtm Reviewers can merge when they approve label Jun 8, 2023
@justinchuby justinchuby requested a review from BowenBao June 8, 2023 16:04
@justinchuby justinchuby force-pushed the justinchu/ort-1.15 branch from f8ffece to 809b189 Compare June 8, 2023 16:05
@justinchuby justinchuby force-pushed the justinchu/ort-1.15 branch from a970f06 to 1d37b3b Compare June 8, 2023 23:40
test_class_name="TestOutputConsistencyFullGraph",
),
xfail(
"nn.functional.upsample_nearest2d",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upsample_bilinear2d is fixed but upsample_nearest2d is not. Weird

Copy link
Contributor

@BowenBao BowenBao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG overall, why do you need opset19?

Bumping ORT introduced opset19 tests into CI?

@justinchuby
Copy link
Collaborator Author

LG overall, why do you need opset19?

Bumping ORT introduced opset19 tests into CI?

Yes it looks like they were discovered. I didn’t look too closely at what happened

@BowenBao
Copy link
Contributor

BowenBao commented Jun 9, 2023

Strange, but won't block on this. Could you follow up?

@BowenBao
Copy link
Contributor

BowenBao commented Jun 9, 2023

Actually wait... do we want to release with Opset19? cc @abock

@justinchuby
Copy link
Collaborator Author

Sure #776

@abock
Copy link
Contributor

abock commented Jun 9, 2023

We should probably not include Opset 19 in this PR? I think while you were away @justinchuby I added support for skipping opsets in opgen:

python -m opgen -x 19 -x 20

@abock
Copy link
Contributor

abock commented Jun 9, 2023

In fact, yes, let's split Opset 19 effort out of this PR since I really need ORT 1.15 for #773.

Copy link
Contributor

@abock abock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-run opgen to drop Opset 19 and open a separate PR for that.

python -m opgen -x 19 -x 20

@justinchuby
Copy link
Collaborator Author

Without opset19 the backend tests fail. I can dig a little deeper

Copy link
Contributor

@abock abock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After speaking with Justin, I had misunderstood why Opset 19 was coming in. We should take it as part of the bump.

@justinchuby justinchuby merged commit 14400a9 into main Jun 9, 2023
@justinchuby justinchuby deleted the justinchu/ort-1.15 branch June 9, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file merge at lgtm Reviewers can merge when they approve

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants