Skip to content

Comments

Revert "feat(atenlib): addOp(var,vardim,varcorrection)"#638

Merged
justinchuby merged 2 commits intomainfrom
revert-569-xiaowu/addOp(var)
Apr 15, 2023
Merged

Revert "feat(atenlib): addOp(var,vardim,varcorrection)"#638
justinchuby merged 2 commits intomainfrom
revert-569-xiaowu/addOp(var)

Conversation

@justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Apr 15, 2023

Reverts #569 due to #634

@justinchuby justinchuby requested a review from xiaowuhu April 15, 2023 00:24
@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Merging #638 (b3217f6) into main (cd14d02) will decrease coverage by 0.09%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #638      +/-   ##
==========================================
- Coverage   73.95%   73.86%   -0.09%     
==========================================
  Files         107      107              
  Lines       11408    11358      -50     
  Branches     1185     1178       -7     
==========================================
- Hits         8437     8390      -47     
+ Misses       2650     2649       -1     
+ Partials      321      319       -2     
Impacted Files Coverage Δ
...s/function_libs/torch_aten/ops_correctness_test.py 89.01% <ø> (-0.03%) ⬇️
onnxscript/function_libs/torch_aten/ops/core.py 74.28% <50.00%> (-0.46%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@justinchuby justinchuby added topic: ci merge at lgtm Reviewers can merge when they approve run release CIs Release CI will run for PRs with this label labels Apr 15, 2023
@justinchuby justinchuby requested a review from fatcat-z April 15, 2023 02:03
@justinchuby
Copy link
Collaborator Author

@xiaowuhu could you approve? Thanks!

@justinchuby justinchuby merged commit b652800 into main Apr 15, 2023
@justinchuby justinchuby deleted the revert-569-xiaowu/addOp(var) branch April 15, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge at lgtm Reviewers can merge when they approve run release CIs Release CI will run for PRs with this label topic: ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants