[torchlib] Simplify aten_trunc implementation#2057
Merged
justinchuby merged 1 commit intomainfrom Feb 14, 2025
Merged
Conversation
Simplify aten_trunc implementation according to onnx/onnx#4588 (comment)
❌ 184 Tests Failed:
View the top 2 failed test(s) by shortest run time
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
|
@justinchuby I have a few more decompositions in this table, but
(I just wandered across your old issue today while writing the WebNN issue and researching whether ONNX and PyTorch supported rounding away from zero - they do not) |
titaiwangms
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify aten_trunc implementation according to onnx/onnx#4588 (comment)
Thanks @fdwr