Skip to content

Unregister aten_linear #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinchuby merged 2 commits into from
Aug 20, 2024
Merged

Unregister aten_linear #1821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2051559
unregister aten_linear
titaiwangms Aug 20, 2024
a4ee8a3
delete tests
titaiwangms Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions onnxscript/function_libs/torch_lib/ops/nn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,7 +822,7 @@ def aten_leaky_relu_backward(
raise NotImplementedError()


@torch_op("aten::linear")
# NOTE: Do not register - We rely on PyTorch decomposition to aten_addmm (Gemm)
def aten_linear(input: TFloat, weight: TFloat) -> TFloat:
"""linear(Tensor input, Tensor weight, Tensor? bias=None) -> Tensor"""

Expand All @@ -833,7 +833,7 @@ def aten_linear(input: TFloat, weight: TFloat) -> TFloat:
return op.MatMul(input, weight_transposed)


@torch_op("aten::linear")
# NOTE: Do not register - We rely on PyTorch decomposition to aten_addmm (Gemm)
def aten_linear_bias(input: TFloat, weight: TFloat, bias: TFloat) -> TFloat:
"""linear(Tensor input, Tensor weight, Tensor? bias=None) -> Tensor"""

Expand Down
14 changes: 0 additions & 14 deletions tests/function_libs/torch_lib/ops_test_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1942,20 +1942,6 @@ def _where_input_wrangler(
or not sample.input.shape,
reason="fixme: Logic not implemented for size 0 inputs in op.Reshape",
),
TorchLibOpInfo("nn.functional.linear", nn_ops.aten_linear).skip(
# input: input, args: weight, bias; so len(args) == 2 means bias is provided
matcher=lambda sample: len(sample.args) != 1,
reason="this overload is implemented for bias=None",
),
TorchLibOpInfo(
"nn.functional.linear_bias",
nn_ops.aten_linear_bias,
tolerance={torch.float16: (2e-1, 4e-4)},
).skip(
# input: input, args: weight, bias; so len(args) == 2 means bias is provided
matcher=lambda sample: len(sample.args) != 2,
reason="this overload is implemented for bias!=None",
),
TorchLibOpInfo(
"nn.functional.max_pool1d",
nn_ops.aten_max_pool1d,
Expand Down