Add simple patterns for llama#1601
Merged
xadupre merged 32 commits intomicrosoft:mainfrom Jun 20, 2024
Merged
Conversation
Signed-off-by: Xavier Dupre <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1601 +/- ##
==========================================
- Coverage 76.41% 75.84% -0.57%
==========================================
Files 240 240
Lines 25294 25500 +206
Branches 4482 4540 +58
==========================================
+ Hits 19328 19341 +13
- Misses 5097 5269 +172
- Partials 869 890 +21 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Xavier Dupre <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Xavier Dupre <[email protected]>
Signed-off-by: Xavier Dupre <[email protected]>
Signed-off-by: Xavier Dupre <[email protected]>
gramalingam
reviewed
Jun 11, 2024
gramalingam
reviewed
Jun 11, 2024
gramalingam
reviewed
Jun 11, 2024
gramalingam
reviewed
Jun 11, 2024
gramalingam
reviewed
Jun 11, 2024
gramalingam
reviewed
Jun 11, 2024
Signed-off-by: Xavier Dupre <[email protected]>
justinchuby
reviewed
Jun 12, 2024
justinchuby
reviewed
Jun 12, 2024
justinchuby
reviewed
Jun 12, 2024
Signed-off-by: Xavier Dupre <[email protected]>
Collaborator
|
For all test models, I would use onnxscript to create them when possible to establish it as the high level api for builiding onnx models. |
justinchuby
reviewed
Jun 12, 2024
justinchuby
reviewed
Jun 12, 2024
justinchuby
reviewed
Jun 12, 2024
justinchuby
reviewed
Jun 12, 2024
Member
Author
I know well the onnx api but not yet onnxscript. The documentation is missing very easy example I can copy paste and change. |
Signed-off-by: Xavier Dupre <[email protected]>
justinchuby
reviewed
Jun 14, 2024
Signed-off-by: Xavier Dupre <[email protected]>
Signed-off-by: Xavier Dupre <[email protected]>
gramalingam
approved these changes
Jun 19, 2024
Signed-off-by: Xavier Dupre <[email protected]>
justinchuby
reviewed
Jun 19, 2024
justinchuby
reviewed
Jun 19, 2024
Comment on lines
1188
to
1196
| if generic: | ||
| import onnxscript.rewriter.generic_pattern as orpp | ||
|
|
||
| return RewriteRule( | ||
| rule_class.pattern, | ||
| rule_class.rewrite, | ||
| rule_class.check, | ||
| orpp.GenericPatternMatcher, | ||
| name=rule_class.__name__, # type: ignore[union-attr] |
Collaborator
There was a problem hiding this comment.
I am concerned about breaking this into different paths again.
justinchuby
reviewed
Jun 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.