Pull request overview

This PR updates the Microsoft.ML.OnnxRuntime.Foundry packaging pipeline and related build/restore behaviors to better support Windows ARM64 and Foundry’s dependency/signing requirements.

Changes:

• Switch Windows ARM64 packaging from --arm64ec to --arm64.
• Add a dedicated Foundry local NuGet packaging stage template with ESRP signing.
• Fix MSBuild props to only copy ARM/ARM64 native DLLs when they exist, avoiding restore/build failures on ARM64 machines for non-ARM64 packages.
• Add a NuGet dependency so Foundry pulls in Microsoft.ML.OnnxRuntime.Gpu.Linux.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Review Summary for PR 27294: Update Microsoft.ML.OnnxRuntime.Foundry Package

Overview

This PR focuses on improving the Microsoft.ML.OnnxRuntime.Foundry package by:

1. Windows ARM64 Support: Switching from arm64ec to pure arm64.
2. Refactoring: Moving packaging logic to a new template foundry-local-nuget-packaging.yml.
3. Bug Fix: Preventing build failures on ARM64 machines when non-native packages invoke props.xml checks.
4. Dependencies: Adding Microsoft.ML.OnnxRuntime.Gpu.Linux as a dependency.
5. Platform Support: Explicit removal of osx-x64 support from this custom package.

Detailed Changes

1. Build Logic Refactoring

File: tools/ci_build/github/azure-pipelines/custom-nuget-packaging-pipeline.yml -> tools/ci_build/github/azure-pipelines/templates/foundry-local-nuget-packaging.yml

• Change: The explicit packaging steps were removed from the main pipeline file and modularized into a new reuseable template foundry-local-nuget-packaging.yml.
• Impact: Improves pipeline readability and reusability. The logic for downloading artifacts, processing them (including the new osx-arm64 directory handling), and signing (ESRP) is now encapsulated.

2. Platform Support Changes (OSX & Windows ARM64)

Files: tools/nuget/generate_nuspec_for_custom_nuget.py, tools/ci_build/github/azure-pipelines/templates/foundry-local-nuget-packaging.yml

• OSX-X64 Removal: The support for osx-x64 has been removed from generate_nuspec_for_custom_nuget.py and is not present in the new pipeline template.
  • Note: Ensure this removal is intentional for the Foundry package.
• Windows ARM64: The PR description mentions "Builds arm64 as opposed to previous arm64ec". The pipeline now explicitly handles win-arm64 artifacts.

3. MSBuild Props Fix

File: csharp/src/Microsoft.ML.OnnxRuntime/targets/netstandard/props.xml

• Change: Added Condition="Exists(...)" checks before copying the native onnxruntime.dll.

  <None Condition="Exists('$(MSBuildThisFileDirectory)..\..\runtimes\win-arm64\native\onnxruntime.dll')" Include="$(MSBuildThisFileDirectory)..\..\runtimes\win-arm64\native\onnxruntime.dll">

• Impact: This is a robust fix. Previously, if a project referenced a package that didn't contain the ARM64 binary (e.g., Microsoft.ML.OnnxRuntime.Gpu which might lack win-arm64 support) on an ARM64 machine, the build would fail trying to copy a non-existent file. This change safely skips the copy if the file is missing.

4. Dependency Updates

File: tools/nuget/generate_nuspec_for_native_nuget.py

• Change: Added dependency for Microsoft.ML.OnnxRuntime.Foundry package.

  if package_name == "Microsoft.ML.OnnxRuntime.Foundry":
      xml_text.append('<dependency id="Microsoft.ML.OnnxRuntime.Gpu.Linux"' + ' version="' + version + '"/>')

• Impact: Ensures that consuming the Foundry package also pulls in the Linux GPU runtime.

Verification & Questions

• Confirm OSX-X64 Removal: The removal of osx-x64 support is clear in the code (generate_nuspec_for_custom_nuget.py). Just double-checking if this aligns with the Foundry package requirements.
• ARM64EC vs ARM64: The switch to arm64 (native) from arm64ec is mentioned. The pipeline changes seem to align with treating it as standard win-arm64.

Conclusion

The changes look solid and address the stated goals. The refactoring improves maintainability, and the props.xml fix is a good quality-of-life improvement for ARM64 developers.

Review Result: Looks good.