Apply absl cuda warning patch to othe OS#27126
Merged
titaiwangms merged 3 commits intomainfrom Jan 26, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request aims to fix CUDA compilation errors on Linux by applying the absl_cuda_warnings.patch to non-Windows platforms. The issue occurs when CUDA code includes abseil headers, causing nvcc to fail with integer conversion errors in abseil's hash implementation.
Changes:
- Modified the patch application logic to apply
absl_cuda_warnings.patchon all platforms (previously only applied on Windows along withabsl_windows.patch) - Windows continues to apply both
absl_windows.patchandabsl_cuda_warnings.patch - Non-Windows platforms now apply only
absl_cuda_warnings.patch
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@titaiwangms I've opened a new pull request, #27127, to work on those changes. Once the pull request is ready, I'll request review from you. |
xiaofeihan1
approved these changes
Jan 26, 2026
Contributor
xiaofeihan1
left a comment
xiaofeihan1
left a comment
There was a problem hiding this comment.
I didn’t notice before that Linux would also fail. Thanks for this fix!
tianleiwu
approved these changes
Jan 26, 2026
Contributor
Author
|
Merging this The CI failure is expected and also found in other PRs: https://github.com/microsoft/onnxruntime/actions/runs/21343213695/job/61427955613?pr=27145 |
milpuz01
pushed a commit
to milpuz01/onnxruntime
that referenced
this pull request
Feb 4, 2026
Fix microsoft#27125 It does fix the build issue on Linux, but I am not entirely sure whether this is the optimal fix.
tianleiwu
pushed a commit
that referenced
this pull request
Feb 12, 2026
Fix #27125 It does fix the build issue on Linux, but I am not entirely sure whether this is the optimal fix.
tianleiwu
added a commit
that referenced
this pull request
Feb 13, 2026
This cherry-picks the following commits for the 1.24.2 release: - #27096 - #27077 - #26677 - #27238 - #27213 - #27256 - #27278 - #27275 - #27276 - #27216 - #27271 - #27299 - #27294 - #27266 - #27176 - #27126 - #27252 --------- Co-authored-by: Xiaofei Han <[email protected]> Co-authored-by: Jiajia Qin <[email protected]> Co-authored-by: Yulong Wang <[email protected]> Co-authored-by: qti-monumeen <[email protected]> Co-authored-by: Ankit Maheshkar <[email protected]> Co-authored-by: Eric Crawford <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: guschmue <[email protected]> Co-authored-by: Guenther Schmuelling <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: angelser <[email protected]> Co-authored-by: Angela Serrano Brummett <[email protected]> Co-authored-by: Misha Chornyi <[email protected]> Co-authored-by: hariharans29 <[email protected]> Co-authored-by: eserscor <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Baiju Meswani <[email protected]> Co-authored-by: Adrian Lizarraga <[email protected]> Co-authored-by: Ti-Tai Wang <[email protected]> Co-authored-by: bmehta001 <[email protected]>
This was referenced Feb 23, 2026
deps(nuget): Bump the microsoft-packages group with 2 updates
Ellerbach/azure-ai-search-simulator#53
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #27125
It does fix the build issue on Linux, but I am not entirely sure whether this is the optimal fix.