Fix early check that prevents a compiled model from being overwritten #26439
+83
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Close and re-open to re-run checks |
Contributor
|
Thanks Adrian. This PR resolves issue:26294 |
chilo-ms
previously approved these changes
Oct 31, 2025
edgchen1
reviewed
Oct 31, 2025
edgchen1
approved these changes
Oct 31, 2025
adrianlizarraga
deleted the
adrianl/fix-old-compile-default-output-path-check
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #26294
When using the old model compilation approach (session option configuration), ORT should verify that the generated output model does not already exist. Importantly, this check should be done before calling an EP's compile() method. This PR fixes this check, which was unintentionally disabled by a previous PR..
Note that this check also (correctly) happens after calling the EP's compile() method, but it is better to catch it early if we can.
Motivation and Context
Fixes a regression in the older compilation workflow.