[QNN EP] Enhance unique name generator for node and tensor names #25702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows x64 QNN CI Pipeline |
|
Azure Pipelines successfully started running 5 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the QNN execution provider by introducing a unique name generator utility to prevent node and tensor name conflicts. The implementation replaces hardcoded name generation with a centralized utility that automatically appends counters to ensure uniqueness.
- Introduces
GetUniqueNameutility functions for generating unique node and tensor names - Replaces hardcoded name concatenations throughout the codebase with centralized name generation
- Updates function calls from
GetNodeNametoGetUniqueNameto utilize the new naming system
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| qnn_utils.h | Declares new GetUniqueName functions to replace GetNodeName |
| qnn_utils.cc | Implements unique name generation logic with static counter and removes old GetNodeName |
| Multiple fusion files | Updates node name generation to use new unique naming utilities |
| Multiple op builders | Replaces hardcoded name generation with GetUniqueName calls |
| qnn_model_wrapper.cc | Updates node creation to use unique names and fixes typo |
HectorSVC
reviewed
Aug 11, 2025
Contributor
|
please fix build error |
Contributor
Author
Will do. Sync issue. :( |
qti-yuduo
force-pushed
the
dev/yuduo/qnn-node-name-cl
branch
from
646e020 to
7cc7abb
Compare
Contributor
|
/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows x64 QNN CI Pipeline |
|
Azure Pipelines successfully started running 5 pipeline(s). |
HectorSVC
pushed a commit
that referenced
this pull request
Aug 14, 2025
Follow up for #25702. Improve thread safety.
gedoensmax
pushed a commit
to gedoensmax/onnxruntime
that referenced
this pull request
Sep 2, 2025
…rosoft#25702) ### Description Enhance unique name generator for node and tensor names ### Motivation and Context QNN requires node name to be unique. We've seen many instance of QNN node name conflicts results in failures on QNN graph finalizations. However, currently it's hard-coded and thus error-prone, this change adds utility to generate unique names used in QNN nodes and intermediate I/O tensors.
gedoensmax
pushed a commit
to gedoensmax/onnxruntime
that referenced
this pull request
Sep 2, 2025
Follow up for microsoft#25702. Improve thread safety.
qti-yuduo
pushed a commit
to CodeLinaro/onnxruntime
that referenced
this pull request
Sep 24, 2025
- pick microsoft#25584 - pick microsoft#25635 - pick microsoft#25673 - pick microsoft#25702 - pick microsoft#25738
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhance unique name generator for node and tensor names
Motivation and Context
QNN requires node name to be unique. We've seen many instance of QNN node name conflicts results in failures on QNN graph finalizations. However, currently it's hard-coded and thus error-prone, this change adds utility to generate unique names used in QNN nodes and intermediate I/O tensors.