[EP ABI] Node_GetAttrByName returns ORT_NOT_FOUND with non-existing attr name #25565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianlizarraga
changed the title
adrianlizarraga
requested review from
chilo-ms and
yuslepukhin
and removed request for
yuslepukhin
edgchen1
reviewed
Jul 29, 2025
edgchen1
approved these changes
Jul 29, 2025
snnn
pushed a commit
that referenced
this pull request
Jul 30, 2025
…ttr name (#25565) ### Description Updates `Node_GetAttributeByName` to return an error status with code `ORT_NOT_FOUND` and set the `attribute` output parameter to `NULL` when called with a non-existing attribute name. Why? Currently, a caller has to do string comparison of the `OrtStatus` error message to determine if the attribute does not exist or if another error occurred. This can be somewhat cumbersome. With this change, the caller can just check the error code. ### Motivation and Context Make it easier to use `Node_GetAttributeByName`.
snnn
pushed a commit
that referenced
this pull request
Jul 30, 2025
- DynamicQuantizeMatMul - handle case where B zero point input is provided but not constant. (#25544) - Refactor plugin EP support (#25541) - Remove the python installation steps from win-qnn-arm64-ci-pipeline.yml (#25552) - [EP ABI] Node_GetAttrByName returns ORT_NOT_FOUND with non-existing attr name (#25565) - Fix C/C++ documentation generation (#25569) - [build] fix multi-config for VCPKG (#25585)
sanketkaleoss
pushed a commit
to sanketkaleoss/onnxruntime
that referenced
this pull request
Aug 11, 2025
…ttr name (microsoft#25565) ### Description Updates `Node_GetAttributeByName` to return an error status with code `ORT_NOT_FOUND` and set the `attribute` output parameter to `NULL` when called with a non-existing attribute name. Why? Currently, a caller has to do string comparison of the `OrtStatus` error message to determine if the attribute does not exist or if another error occurred. This can be somewhat cumbersome. With this change, the caller can just check the error code. ### Motivation and Context Make it easier to use `Node_GetAttributeByName`.
qti-yuduo
pushed a commit
to CodeLinaro/onnxruntime
that referenced
this pull request
Sep 24, 2025
- Fix OrtNodeAttrHelper::Get after the change - microsoft#25565
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
Node_GetAttributeByNameto return an error status with codeORT_NOT_FOUNDand set theattributeoutput parameter toNULLwhen called with a non-existing attribute name.Why? Currently, a caller has to do string comparison of the
OrtStatuserror message to determine if the attribute does not exist or if another error occurred. This can be somewhat cumbersome. With this change, the caller can just check the error code.Motivation and Context
Make it easier to use
Node_GetAttributeByName.