-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Remove the python installation steps from win-qnn-arm64-ci-pipeline.yml #25552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes Python installation steps from Windows ARM64 QNN CI pipelines as the machine images now have Python preinstalled, avoiding potential conflicts.
- Removes manual Python copying scripts from agent tools directory
- Refactors templates to use parameterized Python versions instead of matrix strategy
- Updates pipeline configuration to explicitly specify Python versions
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| win-qnn-arm64-ci-pipeline.yml | Removes Python manual copy script |
| py-win-arm64ec-qnn.yml | Removes unused is1ES parameter |
| py-win-arm64-qnn.yml | Major refactor to use parameterized approach instead of matrix strategy |
| py-cpu-packaging-stage.yml | Updates to use new parameterized template with explicit Python versions |
tools/ci_build/github/azure-pipelines/templates/py-win-arm64-qnn.yml
Outdated
Show resolved
Hide resolved
…nn.yml Co-authored-by: Copilot <[email protected]>
vraspar
approved these changes
Jul 28, 2025
snnn
pushed a commit
that referenced
this pull request
Jul 28, 2025
…ml (#25552) ### Description Yesterday I updated the machine images. Now they already have python preinstalled. We don't need to do this anymore. Remove the steps to avoid conflicts. Also, refactor the yaml file a little bit. Refactors templates to use parameterized Python versions instead of matrix strategy.
Merged
snnn
pushed a commit
that referenced
this pull request
Jul 28, 2025
snnn
pushed a commit
that referenced
this pull request
Jul 30, 2025
- DynamicQuantizeMatMul - handle case where B zero point input is provided but not constant. (#25544) - Refactor plugin EP support (#25541) - Remove the python installation steps from win-qnn-arm64-ci-pipeline.yml (#25552) - [EP ABI] Node_GetAttrByName returns ORT_NOT_FOUND with non-existing attr name (#25565) - Fix C/C++ documentation generation (#25569) - [build] fix multi-config for VCPKG (#25585)
sanketkaleoss
pushed a commit
to sanketkaleoss/onnxruntime
that referenced
this pull request
Aug 11, 2025
…ml (microsoft#25552) ### Description Yesterday I updated the machine images. Now they already have python preinstalled. We don't need to do this anymore. Remove the steps to avoid conflicts. Also, refactor the yaml file a little bit. Refactors templates to use parameterized Python versions instead of matrix strategy.
sanketkaleoss
pushed a commit
to sanketkaleoss/onnxruntime
that referenced
this pull request
Aug 11, 2025
- **DynamicQuantizeMatMul - handle case where B zero point input is provided but not constant. (microsoft#25544)** - **Refactor plugin EP support (microsoft#25541)** - **Remove the python installation steps from win-qnn-arm64-ci-pipeline.yml (microsoft#25552)**
adrianlizarraga
pushed a commit
that referenced
this pull request
Aug 11, 2025
…ml (#25552) Yesterday I updated the machine images. Now they already have python preinstalled. We don't need to do this anymore. Remove the steps to avoid conflicts. Also, refactor the yaml file a little bit. Refactors templates to use parameterized Python versions instead of matrix strategy.
adrianlizarraga
pushed a commit
that referenced
this pull request
Aug 12, 2025
…ml (#25552) Yesterday I updated the machine images. Now they already have python preinstalled. We don't need to do this anymore. Remove the steps to avoid conflicts. Also, refactor the yaml file a little bit. Refactors templates to use parameterized Python versions instead of matrix strategy.
adrianlizarraga
added a commit
that referenced
this pull request
Aug 12, 2025
### Description Cherry-pick PR #25552, which allows building python wheels for ORT 1.22.2 ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Co-authored-by: Changming Sun <[email protected]>
This was referenced Sep 29, 2025
This was referenced Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Yesterday I updated the machine images. Now they already have python preinstalled. We don't need to do this anymore.
Remove the steps to avoid conflicts.
Also, refactor the yaml file a little bit. Refactors templates to use parameterized Python versions instead of matrix strategy.