add back linker flags "-z noexecstack" that were lost by accident #25200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Ah, I'd wondered why that warning had reappeared but didn't have time to run it down yet. |
snnn
approved these changes
Jun 28, 2025
Contributor
|
/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows x64 QNN CI Pipeline |
|
Azure Pipelines successfully started running 5 pipeline(s). |
daijh
pushed a commit
to daijh/onnxruntime
that referenced
this pull request
Jul 10, 2025
…crosoft#25200) ### Description <!-- Describe your changes. --> Add back the linker option to make stack non-executable, which was accidentally lost here: microsoft#22646 This just adds back the option in the same place where it was. ### Motivation and Context After upgrading to 1.22.0 we saw this warning: OpenJDK 64-Bit Server VM warning: You have loaded library /opt/vespa-deps/lib64/libonnxruntime.so.1.22.0 which might have disabled stack guard. The VM will try to fix the stack guard now. It's highly recommended that you fix the library with 'execstack -c <libfile>', or link it with '-z noexecstack'.
Closed
Ma27
added a commit
to Ma27/nixpkgs
that referenced
this pull request
Oct 10, 2025
Failing Hydra build: https://hydra.nixos.org/build/308650242 The libraries require an execstack even though it's not necessary. This got fixed upstream already[1], but this doesn't apply cleanly on the version we have. [1] microsoft/onnxruntime#25200
quic-ankus
pushed a commit
to CodeLinaro/onnxruntime
that referenced
this pull request
Nov 25, 2025
…crosoft#25200) ### Description <!-- Describe your changes. --> Add back the linker option to make stack non-executable, which was accidentally lost here: microsoft#22646 This just adds back the option in the same place where it was. ### Motivation and Context After upgrading to 1.22.0 we saw this warning: OpenJDK 64-Bit Server VM warning: You have loaded library /opt/vespa-deps/lib64/libonnxruntime.so.1.22.0 which might have disabled stack guard. The VM will try to fix the stack guard now. It's highly recommended that you fix the library with 'execstack -c <libfile>', or link it with '-z noexecstack'.
Ma27
added a commit
to Ma27/nixpkgs
that referenced
this pull request
Dec 30, 2025
Failing Hydra build: https://hydra.nixos.org/build/308650242 The libraries require an execstack even though it's not necessary. This got fixed upstream already[1], but this doesn't apply cleanly on the version we have. [1] microsoft/onnxruntime#25200
4 tasks
Ma27
added a commit
to Ma27/nixpkgs
that referenced
this pull request
Jan 3, 2026
Failing Hydra build: https://hydra.nixos.org/build/308650242 The libraries require an execstack even though it's not necessary. This got fixed upstream already[1], but this doesn't apply cleanly on the version we have. [1] microsoft/onnxruntime#25200
Ma27
added a commit
to Ma27/nixpkgs
that referenced
this pull request
Jan 3, 2026
Failing Hydra build: https://hydra.nixos.org/build/308650242 The libraries require an execstack even though it's not necessary. This got fixed upstream already[1], but this doesn't apply cleanly on the version we have. [1] microsoft/onnxruntime#25200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add back the linker option to make stack non-executable, which was accidentally lost here:
#22646
This just adds back the option in the same place where it was.
Motivation and Context
After upgrading to 1.22.0 we saw this warning:
OpenJDK 64-Bit Server VM warning: You have loaded library /opt/vespa-deps/lib64/libonnxruntime.so.1.22.0 which might have disabled stack guard. The VM will try to fix the stack guard now.
It's highly recommended that you fix the library with 'execstack -c ', or link it with '-z noexecstack'.