Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
justinchuby
previously approved these changes
Jul 22, 2025
Co-authored-by: kunal-vaishnavi <[email protected]>
justinchuby
approved these changes
Jul 24, 2025
titaiwangms
approved these changes
Jul 24, 2025
tianleiwu
approved these changes
Jul 25, 2025
Contributor
|
Hi there! We haven't cut the release branch for this version yet, so I'm removing the |
RyanMetcalfeInt8
pushed a commit
to RyanMetcalfeInt8/onnxruntime
that referenced
this pull request
Jul 29, 2025
### Description Implementation Attention(23) for CPU. The backend tests from onnx were wrong for Attention (see onnx/onnx#7142). The onnx version needs to be updated to make all tests pass. The implementation matches the reference implementation after onnx was fixed. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ti-Tai Wang <[email protected]> Co-authored-by: kunal-vaishnavi <[email protected]>
sanketkaleoss
pushed a commit
to sanketkaleoss/onnxruntime
that referenced
this pull request
Aug 11, 2025
### Description Implementation Attention(23) for CPU. The backend tests from onnx were wrong for Attention (see onnx/onnx#7142). The onnx version needs to be updated to make all tests pass. The implementation matches the reference implementation after onnx was fixed. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ti-Tai Wang <[email protected]> Co-authored-by: kunal-vaishnavi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implementation Attention(23) for CPU.
The backend tests from onnx were wrong for Attention (see onnx/onnx#7142). The onnx version needs to be updated to make all tests pass. The implementation matches the reference implementation after onnx was fixed.