[webgpu] Use 1D dispatch groups for attention#24228
Merged
Conversation
fs-eire
previously approved these changes
Apr 4, 2025
fs-eire
approved these changes
Apr 7, 2025
zhaoxul-qti
pushed a commit
to CodeLinaro/onnxruntime
that referenced
this pull request
Apr 17, 2025
This PR uses 1d disptach group size and uses workgroup_idx instead of workgroup.x|workgroup.y in case they are normalized.
qjia7
added a commit
that referenced
this pull request
Apr 25, 2025
Fixed the bug in #24228 which causes the incorrect result for phi models when flash attention is disabled.
vraspar
pushed a commit
that referenced
this pull request
Apr 28, 2025
Fixed the bug in #24228 which causes the incorrect result for phi models when flash attention is disabled.
ankitm3k
pushed a commit
to intel/onnxruntime
that referenced
this pull request
May 12, 2025
Fixed the bug in microsoft#24228 which causes the incorrect result for phi models when flash attention is disabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses 1d disptach group size and uses workgroup_idx instead of workgroup.x|workgroup.y in case they are normalized.