Skip to content

Comments

[TensorRT EP] update oss parser to latest#23710

Merged
yf711 merged 13 commits intomainfrom
yifanl/oss_fix
Feb 27, 2025
Merged

[TensorRT EP] update oss parser to latest#23710
yf711 merged 13 commits intomainfrom
yifanl/oss_fix

Conversation

@yf711
Copy link
Contributor

@yf711 yf711 commented Feb 14, 2025 •
edited
Loading

Description

  • Update oss parser version to latest commit of 10.8-GA branch

Motivation and Context

  • Action needed to adapt latest onnx-tensorrt 10.8-GA branch to fix scatterND attribute issue and plugin.h not found issue

@yf711 yf711 requested a review from chilo-ms February 14, 2025 23:14
@chilo-ms
Copy link
Contributor

chilo-ms commented Feb 15, 2025

The TRT CI has building issue.

@yf711
Copy link
Contributor Author

yf711 commented Feb 18, 2025 •
edited
Loading

onnx-tensorrt introduced a dependency plugin.h, which is available by tarball/zip installation (underTensorRT-tarball/python/include/impl/) but not available by linux package installation. OSS parser users who use Windows/Linux tarball installation are not affected.
Updating the logic to make sure builtin parser users are not blockedThis logic is not needed, as onnx-tensorrt is able to locate the dependency by itself

@jywu-msft
Copy link
Member

jywu-msft commented Feb 19, 2025

this is a bit confusing. if we publish packages built against TRT 10.8 but stay with10.7 parser?

@chilo-ms
Copy link
Contributor

chilo-ms commented Feb 19, 2025 •
edited
Loading

onnx-tensorrt introduced a dependency plugin.h, which is available by tarball/zip installation (underTensorRT-tarball/python/include/impl/) but not available by linux package installation. OSS parser users who use Windows/Linux tarball installation are not affected.
Updating the logic to make sure builtin parser users are not blocked

Why previously when our CI was running with TRT 10.6 built-in parser didn't complain about this plugin.h depedency?

@yf711
Copy link
Contributor Author

yf711 commented Feb 19, 2025

onnx-tensorrt introduced a dependency plugin.h, which is available by tarball/zip installation (underTensorRT-tarball/python/include/impl/) but not available by linux package installation. OSS parser users who use Windows/Linux tarball installation are not affected.
Updating the logic to make sure builtin parser users are not blocked

Why previously when our CI was running with TRT 10.6 built-in parser didn't complain about this plugin.h depedency?

This dependency is only needed by oss parser. CIs that use Bulit-in parser have no issue even though there's no plugin.h

@chilo-ms
Copy link
Contributor

chilo-ms commented Feb 19, 2025

Updating the logic to make sure builtin parser users are not blocked

You mention "Updating the logic to make sure builtin parser users are not blocked", it should be oss parser, right?

chilo-ms
chilo-ms reviewed Feb 19, 2025
View reviewed changes
@yf711
Copy link
Contributor Author

yf711 commented Feb 19, 2025

Updating the logic to make sure builtin parser users are not blocked

You mention "Updating the logic to make sure builtin parser users are not blocked", it should be oss parser, right?

I didn't mention that clearly.
The original code I added (search plugin.h without if check) was a blocker. This part is now removed, as it's not needed.

@yf711 yf711 changed the title [TensorRT EP] revert oss parser to 10.7-GA [TensorRT EP] update oss parser to latest Feb 26, 2025
@yf711 yf711 merged commit 000f2c9 into main Feb 27, 2025
93 of 95 checks passed
@yf711 yf711 deleted the yifanl/oss_fix branch February 27, 2025 01:25
amarin16 pushed a commit that referenced this pull request Feb 27, 2025
@yf711 @amarin16
[TensorRT EP] update oss parser to latest (#23710)
afba3cb 
### Description
<!-- Describe your changes. -->
* Update oss parser version to latest commit of 10.8-GA branch

### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->

* Action needed to adapt latest onnx-tensorrt 10.8-GA branch to fix
scatterND attribute issue and `plugin.h` not found issue
@amarin16 amarin16 mentioned this pull request Feb 27, 2025
Closed
amarin16 pushed a commit that referenced this pull request Feb 27, 2025
@yf711 @amarin16
[TensorRT EP] update oss parser to latest (#23710)
aca623a 
### Description
<!-- Describe your changes. -->
* Update oss parser version to latest commit of 10.8-GA branch

### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->

* Action needed to adapt latest onnx-tensorrt 10.8-GA branch to fix
scatterND attribute issue and `plugin.h` not found issue
@amarin16 amarin16 mentioned this pull request Feb 27, 2025
Merged
amarin16 added a commit that referenced this pull request Feb 28, 2025
@amarin16 @edgchen1
@yf711 @ankitm3k @n1harika
Cherry-picks into rel-1.21.0 (#23846)
beb1a92 
Cherry-pick the following changes into
[rel-1.21.0](https://github.com/microsoft/onnxruntime/tree/rel-1.21.0).
- (#23791)
- (#23710)
- (#23789)
- (#23829)

---------

Co-authored-by: Edward Chen <[email protected]>
Co-authored-by: Yifan Li <[email protected]>
Co-authored-by: Ankit Maheshkar <[email protected]>
Co-authored-by: n1harika <[email protected]>
Co-authored-by: Changming Sun <[email protected]>
guschmue pushed a commit that referenced this pull request Mar 6, 2025
@yf711 @guschmue
[TensorRT EP] update oss parser to latest (#23710)
9dce354 
### Description
<!-- Describe your changes. -->
* Update oss parser version to latest commit of 10.8-GA branch

### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->

* Action needed to adapt latest onnx-tensorrt 10.8-GA branch to fix
scatterND attribute issue and `plugin.h` not found issue
ashrit-ms pushed a commit that referenced this pull request Mar 17, 2025
@amarin16 @edgchen1
@yf711 @ankitm3k @n1harika @ashrit-ms
Cherry-picks into rel-1.21.0 (#23846)
c590806 
Cherry-pick the following changes into
[rel-1.21.0](https://github.com/microsoft/onnxruntime/tree/rel-1.21.0).
- (#23791)
- (#23710)
- (#23789)
- (#23829)

---------

Co-authored-by: Edward Chen <[email protected]>
Co-authored-by: Yifan Li <[email protected]>
Co-authored-by: Ankit Maheshkar <[email protected]>
Co-authored-by: n1harika <[email protected]>
Co-authored-by: Changming Sun <[email protected]>
ankitm3k added a commit to intel/onnxruntime that referenced this pull request Apr 10, 2025
@amarin16 @edgchen1
@yf711 @ankitm3k @n1harika
Cherry-picks into rel-1.21.0 (microsoft#23846)
311f771 
Cherry-pick the following changes into
[rel-1.21.0](https://github.com/microsoft/onnxruntime/tree/rel-1.21.0).
- (microsoft#23791)
- (microsoft#23710)
- (microsoft#23789)
- (microsoft#23829)

---------

Co-authored-by: Edward Chen <[email protected]>
Co-authored-by: Yifan Li <[email protected]>
Co-authored-by: Ankit Maheshkar <[email protected]>
Co-authored-by: n1harika <[email protected]>
Co-authored-by: Changming Sun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chilo-ms chilo-ms chilo-ms left review comments

@jywu-msft jywu-msft jywu-msft approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yf711 @chilo-ms @jywu-msft