[onnxruntime/build] Add CI testing for ORT build with generic interface#23530
[onnxruntime/build] Add CI testing for ORT build with generic interface#23530
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
karim-vad
force-pushed
the
dev/kvadsariya/generic_interface_ci_test
branch
2 times, most recently
from
b6e951e to
64c3a26
Compare
karim-vad
force-pushed
the
dev/kvadsariya/generic_interface_ci_test
branch
from
fbc3229 to
d53cf44
Compare
|
Hi @karim-vad, I'm not fully understanding what this PR is testing. Is it essentially running CI/tests with the combinations:
|
@adrianlizarraga this PR is forcing all the onnxruntime.dll builds with enable_generic_interface flags when the existing CI tests uses one of the primary EPs ( OpenVino, TensorRT, QNN) . The successful execution of the existing CI test validates the Generic interface for ORT is build correctly. In addition to that, cmake system is incorrectly settings certain pre-processor macros when generic interface is enabled. so this PR fixes those as well. The next steps is to figure out how we want to enable CI testing with generic interface flag of ORT ?
|
I see. If these cmake changes should be merged into main, they should probably be extracted and put into a separate PR. (since we are not on merging this experimental PR). This would allow us to get reviews from others who maintain build configs.
From this comment, @snnn indicated that testing all EP combos would not be acceptable due to doubling of resources. Perhaps we can limit this to QNN, TensorRT, OpenVINO. We can start with a PR that only enables this with QNN (as an example). We can use the yaml "strategy matrix" to run tests with strategy:
matrix:
SHARED_LIB:
QnnLibKind: 'shared_lib'
qnn_build_args: '--use_qnn'
STATIC_LIB:
QnnLibKind: 'static_lib'
qnn_build_args: '--use_qnn'
SHARED_LIB_GENERIC_INTERFACE:
QnnLibKind: 'shared_lib'
qnn_build_args: '--use_qnn --use_generic_interface'Maybe something like the above to get us going. |
Summary: - Remove unused cmake variables - Add target specific logic when generic interface is used. - Add QNN EP test case that use ORT generic interface build
karim-vad
force-pushed
the
dev/kvadsariya/generic_interface_ci_test
branch
from
d53cf44 to
ee5cf8b
Compare
karim-vad
changed the title
|
/azp run Linux GPU CI Pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ce (#23530) [onnxruntime/build] Add CI testing for ORT build with generic interface Summary: - Remove unused cmake variables - Add target specific logic when generic interface is used. - Add QNN EP test case that use ORT generic interface build
…ce (#23530) [onnxruntime/build] Add CI testing for ORT build with generic interface Summary: - Remove unused cmake variables - Add target specific logic when generic interface is used. - Add QNN EP test case that use ORT generic interface build
3 participants
[onnxruntime/build] Add CI testing for ORT build with generic interface