Skip to content

Comments

Upgrade min ios version to 13.0#20773

Merged
snnn merged 4 commits intomainfrom
snnn/update_ios
Jun 4, 2024
Merged

Upgrade min ios version to 13.0#20773
snnn merged 4 commits intomainfrom
snnn/update_ios

Conversation

@snnn
Copy link
Contributor

@snnn snnn commented May 22, 2024

To align with Office and other MS products.
Office's support policy is:
"Office for iPad and iPhone is supported on the two most recent versions of iOS and iPadOS. When a new version of iOS or iPadOS is released, the Office Operating System requirement becomes the two most recent versions: the new version of iOS or iPadOS and the previous version." (from https://products.office.com/office-system-requirements)

The latest iOS version is 17. So they support both 17 and 16. Here I set our min iOS version to 13 so that it will be a superset of what Office supports.

This change would allow us using C++17's std::filesystem feature in the core framework. The modifications were generated by running

 find . -type f -exec sed -i "s/apple_deploy_target[ =]12.0/apple_deploy_target=13.0/g"  {} \;

Cannot use 15.0 because otherwise iOS packaging would fail with:

/Users/runner/work/1/b/apple_framework/intermediates/iphoneos_arm64/Release/_deps/coremltools-src/mlmodel/src/MILBlob/Util/Span.hpp:288:9: error: cannot use 'throw' with exceptions disabled
        MILVerifyIsTrue(index < Size(), std::range_error, "index out of bounds");

The Google OSS libraries we use only officially support iOS 15+.

@snnn snnn requested review from a team, edgchen1 and skottmckay May 22, 2024 20:49
@snnn snnn force-pushed the snnn/update_ios branch from 976e4ba to a8d5e0f Compare May 22, 2024 22:05
@snnn snnn changed the title Upgrade min ios version to 15.0 Upgrade min ios version to 14.0 May 22, 2024
@snnn snnn marked this pull request as draft May 22, 2024 23:48
@snnn snnn force-pushed the snnn/update_ios branch from 027b0ea to 79401e3 Compare June 1, 2024 00:01
@snnn snnn changed the title Upgrade min ios version to 14.0 Upgrade min ios version to 13.0 Jun 1, 2024
@snnn snnn marked this pull request as ready for review June 1, 2024 02:27
@snnn snnn merged commit 3dd6fcc into main Jun 4, 2024
@snnn snnn deleted the snnn/update_ios branch June 4, 2024 17:15
snnn pushed a commit that referenced this pull request Jan 9, 2025
Update min iOS version to 15.1 to align with React Native 0.76. We need
to update React Native .
See
react-native-community/discussions-and-proposals#812
for background.

Similar to PR  #20773
tarekziade pushed a commit to tarekziade/onnxruntime that referenced this pull request Jan 10, 2025
…soft#23292)

Update min iOS version to 15.1 to align with React Native 0.76. We need
to update React Native .
See
react-native-community/discussions-and-proposals#812
for background.

Similar to PR  microsoft#20773
guschmue pushed a commit that referenced this pull request Jan 12, 2025
Update min iOS version to 15.1 to align with React Native 0.76. We need
to update React Native .
See
react-native-community/discussions-and-proposals#812
for background.

Similar to PR  #20773
ashrit-ms pushed a commit that referenced this pull request Mar 17, 2025
Update min iOS version to 15.1 to align with React Native 0.76. We need
to update React Native .
See
react-native-community/discussions-and-proposals#812
for background.

Similar to PR  #20773
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants