Removed all the deprecated python training code and related tests and utils#18333
Merged
Removed all the deprecated python training code and related tests and utils#18333
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Lafi7e
reviewed
Nov 15, 2023
Contributor
Lafi7e
left a comment
Lafi7e
left a comment
There was a problem hiding this comment.
Looks like below two files can also be removed:
- onnxruntime/test/python/onnxruntime_test_training_unittest_utils.py
- orttraining/orttraining/python/checkpointing_utils.py
| pass | ||
| raise | ||
| from onnxruntime.training.ortmodule import ORTModule | ||
| from onnxruntime.training.ortmodule._graph_execution_manager_factory import GraphExecutionManagerFactory # noqa: F401 |
Check notice
Code scanning / CodeQL
Unused import
Member
|
It looks good to me. Should we remove this code in two steps: first a warning then a true deletion? |
pengwa
reviewed
Nov 17, 2023
pengwa
previously approved these changes
Nov 17, 2023
Contributor
pengwa
left a comment
pengwa
left a comment
There was a problem hiding this comment.
LGTM. We should add a note in new release for the deprecation information.
Contributor
Author
The warning has been in place for quite some time now: https://github.com/microsoft/onnxruntime/pull/13022/files. This is the second step. |
pengwa
approved these changes
Nov 17, 2023
kleiti
pushed a commit
to kleiti/onnxruntime
that referenced
this pull request
Mar 22, 2024
… utils (microsoft#18333) ### Description Motivation for this PR is code cleanup. 1. Remove all deprecated python code related to orttrainer, old checkpoint, related tests and utils 2. Cleanup orttraining_pybind_state.cc to remove all deprecated bindings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation for this PR is code cleanup.