Skip to content

Update pool to MacOS-13 #17361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jchen351 merged 44 commits into from
Sep 17, 2024
Merged

Update pool to MacOS-13 #17361

jchen351 merged 44 commits into from
Sep 17, 2024

Conversation

@jchen351
Copy link
Contributor

@jchen351 jchen351 commented Aug 30, 2023 •
edited by azure-boards bot
Loading

Description

See microsoft/onnxruntime-extensions#476
and actions/runner-images#7671

Motivation and Context

Current issue

  • For default xcode 15.2, that come with the MacOS-13, We Need to update the boost container header boost/container_hash/hash.hpp version to pass the build
  • For xcode 14.2 The Build passed but the Run React Native Detox Android e2e Test Failed.
    Possible flaky test, Improve stability of Android ReactNative E2E test #21969
  • For xcode 14.3.1 We encountered following issue in Build React Native Detox iOS e2e Tests
ld: file not found: /Applications/Xcode_14.3.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/arc/libarclite_iphonesimulator.a
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Applied following code to the eof in both ios/Podfile and fixed the issue

post_install do |installer|
    installer.generated_projects.each do |project|
        project.targets.each do |target|
            target.build_configurations.each do |config|
                config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '13.0'
            end
        end
    end
end

Applying changes to ios/Pofile

pre_install do |installer|
  # Custom pre-install script or commands
  puts "Running pre-install script..."

  # Recommended fix for https://github.com/facebook/react-native/issues/32483
  # from https://github.com/facebook/react-native/issues/32483#issuecomment-966784501
  system("sed -i '' 's/typedef uint8_t clockid_t;//' \"${SRCROOT}/Pods/RCT-Folly/folly/portability/Time.h\"")
end
  • Detox environment setting up exceeded time out of 120000ms during iso e2e test

dependent

AB#48900

@jchen351 jchen351 requested a review from a team August 30, 2023 23:43
@snnn snnn requested a review from edgchen1 August 31, 2023 00:13
@edgchen1
Copy link
Contributor

edgchen1 commented Aug 31, 2023

FYI, I ran into a build failure earlier when I tried this.
#16618 (comment)

@jchen351 jchen351 closed this May 21, 2024
@jchen351 jchen351 reopened this Jun 21, 2024
@jchen351 jchen351 mentioned this pull request Jun 21, 2024
Closed
2 tasks
@snnn
Copy link
Contributor

snnn commented Jun 24, 2024

Please make sure the Android CI pipeline and ONNX Runtime React Native CI Pipeline could pass.

@snnn
Copy link
Contributor

snnn commented Jun 24, 2024

The "MacOS_C_API_Packaging_CPU_x86_64" build job still uses macOS-12.

skottmckay added a commit that referenced this pull request Jun 25, 2024
@skottmckay
Convert scalars to 1D to satisfy ML Program requirements. Fixes test …
e4110f9 
…failure in #17361

https://dev.azure.com/onnxruntime/onnxruntime/_build/results?buildId=1418617&view=logs&j=f7cc61a9-cc70-56e7-b06c-4668ca17e426&t=16d281b5-1bfd-5309-f274-36d0dffd9cb1&l=27167
@skottmckay skottmckay mentioned this pull request Jun 25, 2024
Merged
jchen351 pushed a commit that referenced this pull request Jun 26, 2024
@skottmckay
Convert scalars to 1D to satisfy ML Program requirements. (#21159)
337cc56 
### Description
<!-- Describe your changes. -->
Convert scalars to 1D to satisfy ML Program requirements.


https://dev.azure.com/onnxruntime/onnxruntime/_build/results?buildId=1418617&view=logs&j=f7cc61a9-cc70-56e7-b06c-4668ca17e426&t=16d281b5-1bfd-5309-f274-36d0dffd9cb1&l=27167

### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
Fixes test failure in #17361
@jchen351 jchen351 closed this Jul 19, 2024
@jchen351 jchen351 reopened this Aug 22, 2024
@jchen351
Copy link
Contributor Author

jchen351 commented Sep 11, 2024 •
edited
Loading 

- task: JavaToolInstaller@0
  displayName: Use jdk 17
  inputs:
    versionSpec: '17'
    jdkArchitectureOption: 'x64'
    jdkSourceOption: 'PreInstalled'

Used to be working prior to 9/11/2024.

jchen351
jchen351 commented Sep 11, 2024
View reviewed changes
@jchen351 jchen351 merged commit fa68ae2 into main Sep 17, 2024
@jchen351 jchen351 deleted the Cjian/macos13 branch September 17, 2024 17:07
@jchen351
Copy link
Contributor Author

jchen351 commented Sep 17, 2024

AB#48900

@mszhanyi mszhanyi mentioned this pull request Sep 18, 2024
Merged
mszhanyi added a commit that referenced this pull request Sep 19, 2024
@mszhanyi
use mac 12 for esrp code sign (#22134)
560778f 
### Description
Fix regression caused by #17361 



### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
@snnn snnn mentioned this pull request Jan 9, 2025
Merged
snnn pushed a commit that referenced this pull request Jan 10, 2025
Update MACOSX_DEPLOYMENT_TARGET (#23308)
ecdeeca 
Fix some inconsistency. 

All our iOS build should target iOS 15.1.
All our macOS desktop build should target macOS 13.3 to align with the
changes made in #17361
guschmue pushed a commit that referenced this pull request Jan 12, 2025
@guschmue
Update MACOSX_DEPLOYMENT_TARGET (#23308)
221c918 
Fix some inconsistency. 

All our iOS build should target iOS 15.1.
All our macOS desktop build should target macOS 13.3 to align with the
changes made in #17361
adrianlizarraga pushed a commit that referenced this pull request Feb 5, 2025
@adrianlizarraga
Update MACOSX_DEPLOYMENT_TARGET (#23308)
cab2be3 
Fix some inconsistency. 

All our iOS build should target iOS 15.1.
All our macOS desktop build should target macOS 13.3 to align with the
changes made in #17361
ashrit-ms pushed a commit that referenced this pull request Mar 17, 2025
@ashrit-ms
Update MACOSX_DEPLOYMENT_TARGET (#23308)
770a71a 
Fix some inconsistency. 

All our iOS build should target iOS 15.1.
All our macOS desktop build should target macOS 13.3 to align with the
changes made in #17361
@snnn snnn mentioned this pull request Apr 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skottmckay skottmckay skottmckay left review comments

@edgchen1 edgchen1 Awaiting requested review from edgchen1

+2 more reviewers

@snnn snnn snnn approved these changes

@carzh carzh carzh left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jchen351 @edgchen1 @snnn @skottmckay @carzh