Fix clang-format comment indents on Windows for winml/#17144
Merged
justinchuby merged 6 commits intomainfrom Aug 15, 2023
Merged
Fix clang-format comment indents on Windows for winml/#17144justinchuby merged 6 commits intomainfrom
justinchuby merged 6 commits intomainfrom
Conversation
On Windows, clang-format has a bug when AlignTrailingComments.Kind is set to Leave (https://clang.llvm.org/docs/ClangFormatStyleOptions.html#aligntrailingcomments), where it will keep adding indentation to comments after each formatting runs. This PR changes to always align comments so we do not hit the bug.
justinchuby
changed the title
justinchuby
force-pushed
the
justinchu/fix-winml-comments
branch
from
9ceb572 to
3e0ccb9
Compare
fdwr
reviewed
Aug 14, 2023
fdwr
approved these changes
Aug 14, 2023
Contributor
fdwr
left a comment
fdwr
left a comment
There was a problem hiding this comment.
So this fixes the issue Pat observed then 👍. TY. Added one minor comment, but otherwise looks fine to me.
snnn
approved these changes
Aug 14, 2023
justinchuby
added a commit
that referenced
this pull request
Aug 16, 2023
Follow up of #17144. Manually fixed indentation in block comments and replaced all tabs with spaces.
kleiti
pushed a commit
to kleiti/onnxruntime
that referenced
this pull request
Mar 22, 2024
On Windows, clang-format has a bug when AlignTrailingComments.Kind is set to `Leave` (https://clang.llvm.org/docs/ClangFormatStyleOptions.html#aligntrailingcomments), where it will keep adding indentation to comments after each formatting runs. This PR changes to always align comments so we do not hit the bug. As a consequence of the options change we need to reformat some of the files. Note that this option is aligned with the rest of the repository.
kleiti
pushed a commit
to kleiti/onnxruntime
that referenced
this pull request
Mar 22, 2024
Follow up of microsoft#17144. Manually fixed indentation in block comments and replaced all tabs with spaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, clang-format has a bug when AlignTrailingComments.Kind is set to
Leave(https://clang.llvm.org/docs/ClangFormatStyleOptions.html#aligntrailingcomments), where it will keep adding indentation to comments after each formatting runs.This PR changes to always align comments so we do not hit the bug.
As a consequence of the options change we need to reformat some of the files. Note that this option is aligned with the rest of the repository.