Skip to content

Comments

js/webgpu: argmax,argmin,softmax support#16882

Merged
guschmue merged 15 commits intomainfrom
gs/softmax
Aug 3, 2023
Merged

js/webgpu: argmax,argmin,softmax support#16882
guschmue merged 15 commits intomainfrom
gs/softmax

Conversation

@guschmue
Copy link
Contributor

argmax and argmin are similar to reduce. Eventually we need to add optimized flavors of the shader.

softmax is optimized but only works on the last axis for now which should be the common use case.

todo: enable more ut for argmax/argmin

@guschmue guschmue added the ep:WebGPU ort-web webgpu provider label Jul 27, 2023
@guschmue guschmue marked this pull request as ready for review July 27, 2023 19:48
@guschmue guschmue requested a review from fs-eire July 28, 2023 22:57
@guschmue guschmue changed the title webgpu: argmax,argmin,softmax support js/webgpu: argmax,argmin,softmax support Aug 1, 2023
satyajandhyala
satyajandhyala previously approved these changes Aug 1, 2023
fs-eire
fs-eire previously approved these changes Aug 2, 2023
@guschmue guschmue dismissed stale reviews from fs-eire and satyajandhyala via 856b04e August 2, 2023 19:42
@guschmue guschmue merged commit 0df2e14 into main Aug 3, 2023
@guschmue guschmue deleted the gs/softmax branch August 3, 2023 01:16
jchen351 pushed a commit that referenced this pull request Aug 12, 2023
argmax and argmin are similar to reduce. Eventually we need to add
optimized flavors of the shader.

softmax is optimized but only works on the last axis for now which
should be the common use case.

todo: enable more ut for argmax/argmin
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
argmax and argmin are similar to reduce. Eventually we need to add
optimized flavors of the shader.

softmax is optimized but only works on the last axis for now which
should be the common use case.

todo: enable more ut for argmax/argmin
siweic0 pushed a commit to siweic0/onnxruntime-web that referenced this pull request May 9, 2024
argmax and argmin are similar to reduce. Eventually we need to add
optimized flavors of the shader.

softmax is optimized but only works on the last axis for now which
should be the common use case.

todo: enable more ut for argmax/argmin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ep:WebGPU ort-web webgpu provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants