Skip to content

[java] Relaxing CoreML test#16777

Merged
ytaous merged 1 commit into
microsoft:mainfrom
Craigacp:java-coreml-test
Aug 9, 2023
Merged

[java] Relaxing CoreML test#16777
ytaous merged 1 commit into
microsoft:mainfrom
Craigacp:java-coreml-test

Conversation

@Craigacp

Copy link
Copy Markdown
Contributor

Description

Reduces precision on the CoreML provider test as it returns slightly different answers than the other tested providers. Checked on a 2020 13" M1 MBP.

Motivation and Context

Fixes Java CoreML test failure after #16763.

@ytaous

ytaous commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

@edgchen1 @YUNQIUGUO - please take a look, thx.

@ytaous
ytaous requested a review from edgchen1 August 8, 2023 20:55
@ytaous

ytaous commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows ARM64 QNN CI Pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed, ONNX Runtime React Native CI Pipeline

@ytaous

ytaous commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, Linux QNN CI Pipeline

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 8 pipeline(s).

1 similar comment
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 8 pipeline(s).

@ytaous

ytaous commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

pls sync again from master for a CI pipeline fix, thx

@Craigacp

Craigacp commented Aug 9, 2023

Copy link
Copy Markdown
Contributor Author

Done.

@ytaous

ytaous commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows ARM64 QNN CI Pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed, ONNX Runtime React Native CI Pipeline

@ytaous

ytaous commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, Linux QNN CI Pipeline

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 8 pipeline(s).

1 similar comment
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 8 pipeline(s).

@ytaous
ytaous merged commit 03c3e91 into microsoft:main Aug 9, 2023
@ytaous

ytaous commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

thx for your contribution

@Craigacp
Craigacp deleted the java-coreml-test branch August 9, 2023 19:09
jchen351 pushed a commit that referenced this pull request Aug 12, 2023
### Description
Reduces precision on the CoreML provider test as it returns slightly
different answers than the other tested providers. Checked on a 2020 13"
M1 MBP.

### Motivation and Context
Fixes Java CoreML test failure after #16763.
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
### Description
Reduces precision on the CoreML provider test as it returns slightly
different answers than the other tested providers. Checked on a 2020 13"
M1 MBP.

### Motivation and Context
Fixes Java CoreML test failure after microsoft#16763.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants