Skip to content

Comments

Modify CANN EP to align with the EP API refactor and fix CANN CI #16490

Merged
jywu-msft merged 1 commit intomicrosoft:mainfrom
zhangsibo1129:fix_cann_ci
Jul 6, 2023
Merged

Modify CANN EP to align with the EP API refactor and fix CANN CI #16490
jywu-msft merged 1 commit intomicrosoft:mainfrom
zhangsibo1129:fix_cann_ci

Conversation

@zhangsibo1129
Copy link
Contributor

@zhangsibo1129 zhangsibo1129 commented Jun 27, 2023

Modify CANN EP CANNExecutionProvider::CreatePreferredAllocators, CANNExecutionProvider::CreateCannAllocator
to align with the EP API refactor and fix CANN CI for #15833 (comment) in this PR

@zhangsibo1129
Copy link
Contributor Author

zhangsibo1129 commented Jun 27, 2023

@microsoft-github-policy-service agree

@zhangsibo1129 zhangsibo1129 mentioned this pull request Jun 27, 2023
Merged
@jywu-msft jywu-msft requested a review from jslhcl June 27, 2023 18:26
@zhangsibo1129
Copy link
Contributor Author

zhangsibo1129 commented Jun 28, 2023

I fixed the CANN EP build for this #15833 (comment), @jywu-msft would you take a look at this PR. Thanks a lot!

thank you, @zhangsibo1129! @jslhcl can you help take a look?

@jslhcl could you help review the code? Thank you!

@jywu-msft
Copy link
Member

jywu-msft commented Jul 5, 2023

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux Nuphar CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, Windows CPU CI Pipeline, Windows GPU CI Pipeline

@jywu-msft
Copy link
Member

jywu-msft commented Jul 5, 2023

/azp run Windows GPU TensorRT CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, onnxruntime-python-checks-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed

@jywu-msft
Copy link
Member

jywu-msft commented Jul 5, 2023

/azp run Linux QNN CI Pipeline, Windows ARM64 QNN CI Pipeline

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 5, 2023

Azure Pipelines successfully started running 2 pipeline(s).

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 5, 2023

Azure Pipelines successfully started running 5 pipeline(s).

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 5, 2023

Azure Pipelines successfully started running 9 pipeline(s).

jslhcl
jslhcl approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@jslhcl jslhcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@zhangsibo1129
Copy link
Contributor Author

zhangsibo1129 commented Jul 6, 2023

@jslhcl @jywu-msft Thank you for your review, helping fix the CANN CI.

@jywu-msft jywu-msft merged commit 180292f into microsoft:main Jul 6, 2023
@zhangsibo1129 zhangsibo1129 deleted the fix_cann_ci branch July 17, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jslhcl jslhcl jslhcl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhangsibo1129 @jywu-msft @jslhcl