Skip to content

DML EP fix training build error#12461

Merged
fdwr merged 1 commit intomasterfrom
user/dwayner/FixDmltrainingBuildError
Aug 5, 2022
Merged

DML EP fix training build error#12461
fdwr merged 1 commit intomasterfrom
user/dwayner/FixDmltrainingBuildError

Conversation

@fdwr
Copy link
Contributor

@fdwr fdwr commented Aug 4, 2022

Description: The combo of --use_dml with --enable_training fails to build with missing linkage errors in {onnxruntime_training_bert.exe, onnxruntime_training_mnist.exe} from onnxruntime_providers_dml.lib not being found (it actually builds fine, but it's not linked to the test apps).

.\build.bat --config Debug --build_shared_lib --parallel --use_dml --skip_tests --skip_submodule_sync --enable_training

Motivation and Context

  • Why is this change required? What problem does it solve? ORT should be buildable with both training and DML. (this alone does not enable training with DML - there is more work elsewhere).
  • If it fixes an open issue, please link to the issue here. NA

@fdwr fdwr requested review from askhade and skottmckay August 4, 2022 03:13
@fdwr fdwr merged commit eb90b52 into master Aug 5, 2022
@fdwr fdwr deleted the user/dwayner/FixDmltrainingBuildError branch August 5, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants