Remove dynamic allocation for ThreadPool ParallelSection#12429
Merged
yuslepukhin merged 2 commits intomasterfrom Aug 4, 2022
Merged
Remove dynamic allocation for ThreadPool ParallelSection#12429yuslepukhin merged 2 commits intomasterfrom
yuslepukhin merged 2 commits intomasterfrom
Conversation
|
This pull request fixes 1 alert when merging a2e777f into c9e0d0f - view on LGTM.com fixed alerts:
|
tlh20
approved these changes
Aug 4, 2022
Contributor
tlh20
left a comment
tlh20
left a comment
There was a problem hiding this comment.
Approve changes, but could you confirm that there is no impact / +ve impact on models using GRU? That's the operator that motivated introducing parallel sections -- when I worked on that, it was used in prod_model10 in our tests
Member
Author
Confirmed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Construct ThreadPool Paralel section in a thread local
std::optional. This allows to avoid repeated dynamic memory allocation.Empty
std::optionalwould construct on the first reference and destructed on thread exit.Motivation and Context
Improve latency variance when running parallel section in a thread pool.