Conversation
natke
approved these changes
Jul 29, 2022
edgchen1
reviewed
Aug 3, 2022
| * | ||
| * \param zero terminated string key to lookup | ||
| * \param key zero terminated string key to lookup | ||
| * \param allocator to allocate memory for the copy of the string returned |
Contributor
There was a problem hiding this comment.
Suggested change
| * \param allocator to allocate memory for the copy of the string returned | |
| * \param allocator allocator to allocate memory for the copy of the string returned |
Contributor
Author
There was a problem hiding this comment.
Yeah, we need to do a bigger pass if we want to fix all those...
edgchen1
approved these changes
Aug 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: A couple of missing parameters generated doxygen compile errors in the doc pipeline.
After these two were fixed, it builds without error (the second error was masked by the first).