Conversation
edgchen1
commented
Jun 22, 2022
| LOAD_FUNCTION(libneuralnetworks, ANeuralNetworksModel_setOperandValue); | ||
| LOAD_FUNCTION_OPTIONAL(libneuralnetworks, ANeuralNetworksModel_setOperandSymmPerChannelQuantParams); | ||
| LOAD_FUNCTION(libneuralnetworks, ANeuralNetworksModel_setOperandValueFromMemory); | ||
| LOAD_FUNCTION_OPTIONAL( |
Contributor
Author
There was a problem hiding this comment.
some formatting changes were made to minimize the diff from the TF Lite version of this file
YUNQIUGUO
reviewed
Jun 22, 2022
| TENSOR_BOOL8 = ANEURALNETWORKS_TENSOR_BOOL8, | ||
| FLOAT16 = ANEURALNETWORKS_FLOAT16, | ||
| TENSOR_QUANT8_SYMM_PER_CHANNEL = ANEURALNETWORKS_TENSOR_QUANT8_SYMM_PER_CHANNEL, | ||
| TENSOR_QUANT16_ASYMM = ANEURALNETWORKS_TENSOR_QUANT16_ASYMM, |
Contributor
There was a problem hiding this comment.
why are we removing TENSOR_QUANT16_ASYMM/FLOAT16 types here?
is it to align with TF lite latest version
Contributor
Author
There was a problem hiding this comment.
edgchen1
commented
Jun 22, 2022
| @@ -0,0 +1,245 @@ | |||
| // Copyright (c) Microsoft Corporation. All rights reserved. | |||
Contributor
Author
There was a problem hiding this comment.
move stubs into a separate file to minimize nnapi_implementation.cc diff with TF Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the NNAPI headers to a more recent version (copied from TF Lite v2.9.1).
Motivation and Context
Enables use of newer NNAPI functionality such as the ANEURALNETWORKS_BATCH_MATMUL operation.