You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description: The CPU EP MVN kernel doesn't actually support the axes parameter (any arbitrary axes), which caused some test failures when comparing against the DML EP (which fully supports axes). Not supporting them is okay, but what's worse is that the code silently returns the wrong results for unsupported combinations, like HW and NC, which get mapped incorrectly to NHW and NCHW respectively. This change more robustly checks the axes parameter, rather than just checking for the presence of axis 1 without checking the other axes, given the CPU EP only supports 4D NCHW and NHW.
Motivation and Context
Why is this change required? What problem does it solve?
Description: The CPU EP MVN kernel doesn't actually support the axes parameter (any arbitrary axes), which caused some test failures when comparing against the DML EP (which fully supports axes). Not supporting them is okay, but what's worse is that the code silent returns the wrong results for unsupported combinations, like HW and NC, which get mapped blindly and incorrectly to NCHW. This change more robustly checks the axes parameter, rather than just checking for the presence of axis 1 without checking the other axes, given the CPU EP only supports 4D NCHW and NHW.
Motivation and Context
Why is this change required? What problem does it solve?
fdwr
deleted the
user/dwayner/MeanVarianceNormalizationV9Validation
branch
June 22, 2022 19:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: The CPU EP MVN kernel doesn't actually support the
axesparameter (any arbitrary axes), which caused some test failures when comparing against the DML EP (which fully supportsaxes). Not supporting them is okay, but what's worse is that the code silently returns the wrong results for unsupported combinations, like HW and NC, which get mapped incorrectly to NHW and NCHW respectively. This change more robustly checks theaxesparameter, rather than just checking for the presence of axis 1 without checking the other axes, given the CPU EP only supports 4D NCHW and NHW.Motivation and Context