Eager mode: Argmax and fixup max and min.#11861
Merged
WilBrady merged 3 commits intomicrosoft:masterfrom Jun 23, 2022
Merged
Conversation
WilBrady
force-pushed
the
wilbrady/investigating
branch
from
9477c3b to
f77c3ce
Compare
jamill
reviewed
Jun 16, 2022
jamill
reviewed
Jun 16, 2022
jamill
reviewed
Jun 16, 2022
jamill
reviewed
Jun 16, 2022
WilBrady
force-pushed
the
wilbrady/investigating
branch
from
c303f81 to
0a920e5
Compare
souptc
reviewed
Jun 21, 2022
WilBrady
force-pushed
the
wilbrady/investigating
branch
2 times, most recently
from
ca8a35c to
ee2c025
Compare
WilBrady
force-pushed
the
wilbrady/investigating
branch
from
ee2c025 to
29e7acc
Compare
WilBrady
force-pushed
the
wilbrady/investigating
branch
from
29e7acc to
b887221
Compare
Contributor
Author
|
@souptc - please review and approve or provide feedback. Thank you. |
souptc
approved these changes
Jun 23, 2022
jamill
reviewed
Jun 23, 2022
|
|
||
| // generator also needs to do this to handle the out param! | ||
| out = aten_tensor_from_ort( | ||
| std::move(ort_outputs_0_ArgMax[0]), |
Member
There was a problem hiding this comment.
nit: could we check the indentation here (and some of the places above)?
jamill
approved these changes
Jun 23, 2022
Member
jamill
left a comment
jamill
left a comment
There was a problem hiding this comment.
Looks good to me! Just left a comment about whether we can improve the indentation for the manual code. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Adding argmax support to eager mode, correcting min and max behavior, and adding tests.
Motivation and Context