Conversation
guoyu-wang
reviewed
Feb 13, 2022
guoyu-wang
approved these changes
Feb 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The return type of GetAttrs is Status, so it is better to return a Status instead of throwing an exception when errors happen.
It's very tricky that if you want to read a tensor shape from attrs, you can either use a std::vector or TensorShapeVector to store the data. However, if you use TensorShapeVector you must pre-compute the number of dimension before calling GetAttrs and resize the vector to the right size. std::vector doesn't have the restriction.
Motivation and Context
Make error message more readable.